Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide tarballs without LFS references #8

Open
agx opened this issue Sep 20, 2023 · 4 comments
Open

Please provide tarballs without LFS references #8

agx opened this issue Sep 20, 2023 · 4 comments
Assignees

Comments

@agx
Copy link
Contributor

agx commented Sep 20, 2023

Getting e.g. the tarball for the 1.8.0 release one has:

$ cat schemes-1.8.0/schemes/ml/symbol-frequency-report.txt 
version https://git-lfs.github.com/spec/v1
oid sha256:9d24c8a04d3bf8f54c6236de7c9fa002e37eaf6d27a8e3bacab8844262aec76d
size 13049

This makes distro packaging hard as the tarball isn't usable as is to rebuild the scheme files. Please consider shipping the files as is.

@subins2000
Copy link
Member

@agx Would it be alright that the tarball with full files are included in a release file here? https://github.com/varnamproject/schemes/releases

A link like https://github.com/varnamproject/schemes/releases/download/v1.8.0/with-lfs.zip

@agx
Copy link
Contributor Author

agx commented Sep 23, 2023

@subins2000 at least for my use case (downloading the source tarballs for Debian packaging) that wold work and help a lot, thanks for considering this.

The files are rather small, maybe disabling LFS for them could also be a solution? But maybe you expect them to grow considerably in size and number in the future?

@subins2000
Copy link
Member

I've added this now https://github.com/varnamproject/schemes/releases/download/v1.8.0/source-with-lfs.zip (It's basically this repo source with all the LFS files in it). Please let me know if this is enough, thanks.

But maybe you expect them to grow considerably in size and number in the future?

Yes that is precisely the reason, I expect them to grow in the future.

@agx
Copy link
Contributor Author

agx commented Sep 25, 2023

The *.txt files in the package look good, thanks a lot! Some things I noticed:

  • the archive doesn't carry the project name and version number anymore (s.th. like schemes-1.9.0-source-with-lfs.zip) would be great to have that so downloading different versions is distinguishable
  • Using gz or xz instead of zip would be nice as we can then use them verbatim without repackaging from zip to s.th. else
  • the archive doesn't have the project and version in the directory anymore (e.g. when you download the current tarballs they end up in schemes-1.9.0/ while the one you linked unpacks directly into ./
  • there's a .DS_STORE in the archive which isn't in the original one

@subins2000 subins2000 self-assigned this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants