We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
def _getSessionEstimate(self, positionRelevances, layout, clicks, intent): .... gamma = self.getGamma(self.gammas, k, layout, intent) # E_k_multiplier --- P(S_k = 0 | C_k) P(C_k | E_k = 1) if C_k == 0: sessionEstimate['a'][k] = a_u * varphi[k][0] sessionEstimate['s'][k] = 0.0 else: sessionEstimate['a'][k] = 1.0 sessionEstimate['s'][k] = varphi[k + 1][0] * s_u / (s_u + (1 - gamma) * (1 - s_u)) ....
In the above function, sessionEstimate['a'][k] = a_u * varphi[k][0] mybe wrong,it should be a_u * varphi[k][1]?
reason:a_u = P(C_k = 1 | E_k = 1 ) varphi[k][1] = P( E_k = 1 |C_1, C_2, C_3,.....C_N )
so: sessionEstimate['a'][k] = P(C_k = 1 | C_1, C_2, C_3,.....C_N) = P(C_k = 1 | E_k = 1 ) * P( E_k = 1 |C_1, C_2, C_3,.....C_N ) = a_u * varphi[k][1]
Do you agree with my opinion ? Please help me solve it,thank you.
The text was updated successfully, but these errors were encountered:
Thanks for your report. I've updated the comment in the function to hopefully make it clearer. Basically, in this part of the code branch C_k = 0, so
C_k = 0
sessionEstimate['a'][k] = P(A_k = 1 | C_1, C_2, ..., C_N) = P(A_k = 1 | C_k = 0) = P(A_k = 1, C_k = 0) / P(C_k = 0) = P(A_k = 1, C_k = 0) = P(A_k = 1) * P(C_k = 0 | A_k = 1) = a_u * varphi[k][0]
Sorry, something went wrong.
No branches or pull requests
def _getSessionEstimate(self, positionRelevances, layout, clicks, intent):
....
gamma = self.getGamma(self.gammas, k, layout, intent)
# E_k_multiplier --- P(S_k = 0 | C_k) P(C_k | E_k = 1)
if C_k == 0:
sessionEstimate['a'][k] = a_u * varphi[k][0]
sessionEstimate['s'][k] = 0.0
else:
sessionEstimate['a'][k] = 1.0
sessionEstimate['s'][k] = varphi[k + 1][0] * s_u / (s_u + (1 - gamma) * (1 - s_u))
....
In the above function, sessionEstimate['a'][k] = a_u * varphi[k][0] mybe wrong,it should be a_u * varphi[k][1]?
reason:a_u = P(C_k = 1 | E_k = 1 )
varphi[k][1] = P( E_k = 1 |C_1, C_2, C_3,.....C_N )
so:
sessionEstimate['a'][k] = P(C_k = 1 | C_1, C_2, C_3,.....C_N) = P(C_k = 1 | E_k = 1 ) * P( E_k = 1 |C_1, C_2, C_3,.....C_N ) = a_u * varphi[k][1]
Do you agree with my opinion ? Please help me solve it,thank you.
The text was updated successfully, but these errors were encountered: