Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np.isnan() should be changed as df.isna() #13

Open
Fumire opened this issue Apr 14, 2021 · 0 comments
Open

np.isnan() should be changed as df.isna() #13

Fumire opened this issue Apr 14, 2021 · 0 comments

Comments

@Fumire
Copy link

Fumire commented Apr 14, 2021

if np.isnan(group):

There is no limitation for the value of the groups:

The value of the groups does not matter as long as samples in the same group have the same value.

However, if group column has str type, than np.isnan() will throw exception as:
image

This will be easily solved with changing to df.isna().
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant