Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workstump + TerraFirmaCraft = crash #43

Open
ChaosTheLegend opened this issue Oct 28, 2020 · 0 comments
Open

Workstump + TerraFirmaCraft = crash #43

ChaosTheLegend opened this issue Oct 28, 2020 · 0 comments

Comments

@ChaosTheLegend
Copy link

ChaosTheLegend commented Oct 28, 2020

Description:
Crash happens when you try to craft anything involving TFC tools on a workstump(both versions)
this also corrupts the world

To Reproduce:
Craft anything involving a TFC tool in the recipe on a workstump

I've already sent this issue to TFC devs and they said the following:

In vanilla, calling CraftingManger#getRemainingItems is done in exactly one place, and it is guarded by two forge hooks...
...Resulting in the fact that ForgeHooks.getCraftingPlayer() is not null during the process of getting the remaining items. TFC's shapeless damage recipe uses this fact - damaging items requires access to a player (e.g. to test if the player is in creative mode).

Link to the issue on TFC side: TerraFirmaCraft/TerraFirmaCraft#1620

TFC version - 1.7.6.164
primaltech version - 0.3.5

all further info, as well as crash reports, are on the TFC thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant