Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for java8 date time in signals #2899

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: add support for java8 date time in signals #2899

wants to merge 5 commits into from

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Nov 8, 2024 •
edited
Loading

Description

This introduces endpointObjectMapper bean to be used in both the EndpointInvoker and in the Signals library.
If the user overrides the JacksonObjectMapperFactory by the EndpointController.ENDPOINT_MAPPER_FACTORY_BEAN_QUALIFIER qualifier, it also by default affects the the object mapper in the signals library.

Fixes #2891

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (5213899) to head (b44f7d8).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2899   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          83       83           
  Lines        2831     2831           
  Branches      729      729           
=======================================
  Hits         2623     2623           
  Misses        156      156           
  Partials       52       52
Flag Coverage Δ
unittests 92.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review November 9, 2024 00:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ListSignal with Java 8 date/time types fail with Jackson ObjectMapper
1 participant
@taefi