spacewalk-report broken with Python Import error after recent O/S package update

[ppanon2022]

Hi,

spacewalk-report is now returning the following exception:

\# spacewalk-report myreport
Traceback (most recent call last):
  File "/usr/bin/spacewalk-report", line 31, in <module>
    from salt.ext import six
ImportError: cannot import name 'six'
[ERROR   ] An un-handled exception was caught by Salt's global exception handler:
ImportError: cannot import name 'six'
Traceback (most recent call last):
  File "/usr/bin/spacewalk-report", line 31, in <module>
    from salt.ext import six
ImportError: cannot import name 'six'

This was working until fairly recently so I think an O/S package update must have changed whatever the salt.ext six module is. I think six is usually a python 2/3 compatibility layer so perhaps it was removed in a recent package update under the assumption that it's been long enough for people to switch over code to Python 3. Can anybody confirm if that's the problem and clarify what spacewalk-report is using that six module for?

As far as I can tell it's being used as an iterator when building the where clause to append to the select query.

248             for column in where:
249                 if column not in report.columns:
250                     systemExit(-6, 'Unknown column [%s] in report [%s].' % (column, report_name))
251                 for v in (val for vals in where[column].values() for val in vals):
252                     if report.column_types[column] == 'i' and not re.match('^[0-9]+$', v):
253                         systemExit(-7, 'Column [%s] in report [%s] only accepts integer value.' % (column, report_name))
254
255                 for clause, values in six.iteritems(where[column]):
256                     l = []
257                     for v in values:
258                         l.append(':p%d' % pi)
259                         the_dict_where['p%d' % pi] = v
260                         pi += 1
261
262                     # Column named "group" can be a little complicated...
263                     if column.lower() == 'group':
264                        column = '"%s"' % column.lower()
265
266                     if clause == 'where':
267                         conjunct = '%s in ( %s )' % (column, ", ".join(l))
268                     elif clause == 'ne-where':
269                         conjunct = '%s not in ( %s )' % (column, ", ".join(l))
270                     elif clause == 'le-where':
271                         conjunct = " and ".join('%s <= %s' % (column, v) for v in l)
272                     elif clause == 'ge-where':
273                         conjunct = " and ".join('%s >= %s' % (column, v) for v in l)
274                     elif clause == 'like':
275                         conjunct = " and ".join('%s like %s' % (column, v) for v in l)
276                     else:
277                         assert False, "Unsupported clause"
278
279                     the_sql_where.append(conjunct)
280
281             rhnSQL.initDB(reportdb=options.use_reportdb)

I'm not sure what that function is doing though or if there's a Python 3 equivalent that should just be used to replace it. Could it just be replaced by the following?
for clause, values in enumerate(where[column]):

Ah, that just seems to move the problem to /usr/share/spacewalk/reports.py

 # spacewalk-report system-vulnsummary
Traceback (most recent call last):
  File "/usr/bin/spacewalk-report", line 37, in <module>
    import reports
  File "/usr/share/spacewalk/reports.py", line 6, in <module>
    from salt.ext import six
ImportError: cannot import name 'six'
[ERROR   ] An un-handled exception was caught by Salt's global exception handler:
ImportError: cannot import name 'six'
Traceback (most recent call last):
  File "/usr/bin/spacewalk-report", line 37, in <module>
    import reports
  File "/usr/share/spacewalk/reports.py", line 6, in <module>
    from salt.ext import six
ImportError: cannot import name 'six'

where it's being used in exception handling

        def _load(self, full_path):
                try:
                        fd = open(full_path, 'r')
                except (IOError):
                        six.reraise(spacewalk_unknown_report, None, sys.exc_info()[2])

I've tried to change that last line to just
raise spacewalk_unknown_report
and the report now runs, but I don't know if that's the correct fix.

[digdilem-work]

Quick check done here, and "spacewalk-report" is working as before.

HOWEVER, I have not done any recent OS package updates, since there hasn't been a new version of Uyuni for a while, which perhaps adds weight to your theory.

[agraul]

salt.ext.six was provided by Salt, but it has since been dropped. I removed the usage in 23b4580 and d4c74f9. It will be included in the next Uyuni release, but you can also monkey-patch the Python source code in your installation.