Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Collision group logic is very messy #38

Open
mwillsey opened this issue Oct 2, 2018 · 0 comments
Open

Collision group logic is very messy #38

mwillsey opened this issue Oct 2, 2018 · 0 comments
Labels
A-execution Relating to error detection/correction, simulation, control T-cleanup

Comments

@mwillsey
Copy link
Member

mwillsey commented Oct 2, 2018

Collision group logic is very messy, needlessly complicating all sorts of things.

It introduces unnecessary mutability:

// FIXME this shouldn't be mut, but we need to set the collision groups in mix
fn dynamic_info(&self, &mut GridView) -> DynamicCommandInfo;

It also just makes the routing waaaay more complicated (and probably) buggy. We could fix this by having some cleaner (non-mutating) way of asking the router to allow things to collide. This would also be cleaner because we will actually know when the mix occurs, allowing us to update the droplet.

@mwillsey mwillsey added A-execution Relating to error detection/correction, simulation, control T-cleanup labels Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-execution Relating to error detection/correction, simulation, control T-cleanup
Projects
None yet
Development

No branches or pull requests

1 participant