Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension can't remove the forgotten colon #11

Open
GlebIgorevich opened this issue Aug 16, 2023 · 2 comments
Open

Extension can't remove the forgotten colon #11

GlebIgorevich opened this issue Aug 16, 2023 · 2 comments

Comments

@GlebIgorevich
Copy link

An example of prompt
a cute woman, green (sundress:1.3) : sitting on the grass

The extension did not remove forgotten : but it removed spaced around that. This is not a critical problem but fixing that may be helpful sometimes.

@uwidev
Copy link
Owner

uwidev commented Aug 17, 2023

Removing spaces between colons is done to correct weights, but looking at this now, my approach and straight up removing the colon doesn't sound right either.

Removing spaces is meant to correct weights, however, after some testing, SD doesn't apply weights if they aren't wrapped in parenthesis (which I thought it did). So to fix this, colon-space fixing should only be done on parenthesis.

some title :some edition, (yellow : 0.3)
== current => some title :some edition, (yellow:0.3)
== proposed => some title :some edition, (yellow:0.3)

But as for colons outside of parenthesis, I'm not too sure, but I think it's best to assume it's part of the prompt tag and not immediately remove it; perhaps have it remove the spaces before the colon, but have one space after like: this.

== proposed' => some title: some edition, (yellow:0.3)

What are your thoughts?

@GlebIgorevich
Copy link
Author

I think if there are no numbers after the colons you can delete that. Because some title : some edition, is not the correct syntax.

But if the colons are in the squared brackets you must be careful because this syntax is correct:
[some title : some edition : 0.5]
[some title :: 0.5]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants