Form is passed as the final argument to event handlers #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vladbalan Looks like we didn't fully think through this api, the reason that our test fails is because we were assuming that the last argument passed to a triggered event was the data for our event, and that the other arguments were syntactic sugar (e.g. the doc), but when we added the form argument we placed it on the end, which means it is treated as the most significant argument. We should either:
It bothers me to have 5 arguments to an event function, but I think that would be the best solution from the stand point of someone using it, but not perfect. Suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form that triggered an event is now passed as the last argument. This closes #22