Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scon value parser with scale_value parser #1600

Open
smiasojed opened this issue Apr 17, 2024 · 0 comments
Open

Replace scon value parser with scale_value parser #1600

smiasojed opened this issue Apr 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@smiasojed
Copy link
Collaborator

Currently, both options are being used, each with similar functionality but employing slightly different grammar. This discrepancy requires RPC command parameters to be formatted differently from other commands.

scale_value parser: https://github.com/paritytech/scale-value/blob/372a74870d46f9b4d681807bdc8d49724abcdef4/src/string_impls/from_string.rs#L60

scon value parser: https://github.com/paritytech/cargo-contract/blob/3d74a06c62b664fe5e2d684a11b7f7b44cf65f63/crates/transcode/src/scon/parse.rs#L59

@smiasojed smiasojed added the enhancement New feature or request label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant