You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Read the MAJORink version from the contract's Cargo.toml
Take that number (e.g. 5) and form it into v5.x.x
Fetch the lints from the ink repository at the branch v5.x.x, instead of at a fixed GIT_REV
Right now, the linter uses the lints from GIT_REV for a contract of an arbitrary ink version. It's more future proof to have it fetch the lints for that particular ink! version. Also, we won't have to update cargo-contract any time we release new lints for an ink! version.
The text was updated successfully, but these errors were encountered:
When the linter is run for a contract, we fetch the lints at this commit from the ink! repo:
(source)
I think what we should do instead:
MAJOR
ink
version from the contract'sCargo.toml
5
) and form it intov5.x.x
ink
repository at the branchv5.x.x
, instead of at a fixedGIT_REV
Right now, the linter uses the lints from
GIT_REV
for a contract of an arbitraryink
version. It's more future proof to have it fetch the lints for that particular ink! version. Also, we won't have to updatecargo-contract
any time we release new lints for an ink! version.The text was updated successfully, but these errors were encountered: