Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where/how is it saving locally? #50

Open
peter-lyons-kehl opened this issue Oct 28, 2022 · 5 comments
Open

Where/how is it saving locally? #50

peter-lyons-kehl opened this issue Oct 28, 2022 · 5 comments

Comments

@peter-lyons-kehl
Copy link

Thank you for Tab Groups, Usama.

Summary: Can't seem to save locally or can't locate where it saves (current VS Code, current Tab Groups).

Current Manjaro Linux (x64 5.19.16-2 kernel, I don't use 6 yet; local filesystem ext4 (rw,noatime,discard,nobarrier,commit=60) - hence most likely not related to #26). VS Code:

  • Version: 1.72.2
  • Commit: d045a5eda657f4d7b676dedbfa7aab8207f8a075
  • Date: 2022-10-12T22:16:26.920Z
  • Electron: 19.0.17
  • Chromium: 102.0.5005.167
  • Node.js: 16.14.2
  • V8: 10.2.154.15-electron.0
  • OS: Linux x64 5.19.16-2-MANJARO
  • Sandboxed: No

Tab Groups v. v2.1.1 as installed from the Marketplace:
image

Tab Groups configured not to store globally:

grep tab ~/.config/Code/User/settings.json
    "workbench.editor.tabCloseButton": "off",
    "tab-groups.relativePaths": true,
    "tab-groups.saveGlobally": false

image

It seems to save the tabs somewhere, but it's not under the workspace's .vscode/:
image

image

Did I misunderstand #1 or #4? I've re-started VS Code a few times, still the same behavior.

I created a new tab group tab-group-01. Restarted VS Code, and the group shows up:
image

However, tab-group-01 (verbatim) is not anywhere under the workspace, neither under ~/.config/Code:

~/.config/Code 
❯ grep -r tab-group-01 .

~/.config/Code took 8s
❯
present_on_github_with_reveal.js on  main [!+?] via  v18.10.0 took 9s 
❯ grep -r tab-group-01 . .vscode

present_on_github_with_reveal.js on  main [!+?] via  v18.10.0
❯
@peter-lyons-kehl
Copy link
Author

The exact same was reported by Robbie Estes on 13th Oct 2022:
image

@peter-lyons-kehl
Copy link
Author

Related to #47.

@peter-lyons-kehl peter-lyons-kehl changed the title Where/how is it saving locally? [Feature Request] Where/how is it saving locally? Oct 28, 2022
@peter-lyons-kehl peter-lyons-kehl changed the title [Feature Request] Where/how is it saving locally? Where/how is it saving locally? Oct 28, 2022
@usama8800
Copy link
Owner

It used to be stored in .vscode/settings.json but I changed it to store in the workspaceStorage or globalStorage folders in the code/User folder. The code folder is located in %APPDATA%/Roaming/ on windows

@usama8800
Copy link
Owner

Related to #47.

I guess I could implement this by making the save location editable and it's own separate file. This would also fix your problem

@antenando
Copy link

I couldn't find these files in windows. Could you please provide an answer?! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants