From fcb9a63bbbcd164df531cdc6eed443b4eb7d4e18 Mon Sep 17 00:00:00 2001 From: Youssef Victor Date: Sat, 22 Jul 2023 13:11:44 +0300 Subject: [PATCH 1/2] test: Unskip ContentDialog leak test --- .../Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs index 207369e7db62..9bfdc3aba28f 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs +++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs @@ -118,9 +118,7 @@ public class Given_FrameworkElement_And_Leak [DataRow("UITests.Windows_UI_Xaml_Controls.ToolTip.ToolTip_LeakTest", 15)] [DataRow("Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml.Controls.Button_Command_Leak", 15)] [DataRow("Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml.Controls.ItemsControl_ItemsSource_Leak", 15)] -#if !__WASM__ && !__IOS__ // Disabled - https://github.com/unoplatform/uno/issues/7860 [DataRow("Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml.Controls.ContentDialog_Leak", 15)] -#endif #if !__IOS__ // Disabled - #10344 [DataRow(typeof(TextBox_Focus_Leak), 15)] [DataRow(typeof(PasswordBox_Focus_Leak), 15)] From 339eb6ea39ed22e8f27c82ae8724b7c5a564e493 Mon Sep 17 00:00:00 2001 From: Youssef Victor Date: Sun, 23 Jul 2023 11:51:15 +0300 Subject: [PATCH 2/2] chore: Disable again on iOS --- .../Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs index 9bfdc3aba28f..e33dace4e7ff 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs +++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs @@ -118,7 +118,9 @@ public class Given_FrameworkElement_And_Leak [DataRow("UITests.Windows_UI_Xaml_Controls.ToolTip.ToolTip_LeakTest", 15)] [DataRow("Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml.Controls.Button_Command_Leak", 15)] [DataRow("Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml.Controls.ItemsControl_ItemsSource_Leak", 15)] +#if !__IOS__ // Disabled - https://github.com/unoplatform/uno/issues/7860 [DataRow("Uno.UI.RuntimeTests.Tests.Windows_UI_Xaml.Controls.ContentDialog_Leak", 15)] +#endif #if !__IOS__ // Disabled - #10344 [DataRow(typeof(TextBox_Focus_Leak), 15)] [DataRow(typeof(PasswordBox_Focus_Leak), 15)]