From 4157cc5230c98412e605a1ee8fd371176b853603 Mon Sep 17 00:00:00 2001 From: Youssef Victor Date: Fri, 12 May 2023 00:15:48 +0300 Subject: [PATCH 1/3] fix!: Make `ToggleButton.OnIsCheckedChanged` internal --- src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs b/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs index fd91a2c08250..6bdb33ab2a73 100644 --- a/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs +++ b/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs @@ -87,7 +87,7 @@ public bool IsThreeState /// internal bool CanRevertState { get; set; } = true; - protected virtual void OnIsCheckedChanged(bool? oldValue, bool? newValue) + private void OnIsCheckedChanged(bool? oldValue, bool? newValue) { // This workaround can be removed if pooling is removed. See https://github.com/unoplatform/uno/issues/12189 if (_suppressCheckedChanged) From 637de803305a48d1d8098c2e5ed24dcb6ef47833 Mon Sep 17 00:00:00 2001 From: Youssef Victor Date: Fri, 12 May 2023 09:27:46 +0300 Subject: [PATCH 2/3] chore: Remove unused method --- .../Xaml/Controls/Primitives/ToggleButton.cs | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs b/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs index 6bdb33ab2a73..07f4a5505e76 100644 --- a/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs +++ b/src/Uno.UI/UI/Xaml/Controls/Primitives/ToggleButton.cs @@ -87,31 +87,6 @@ public bool IsThreeState /// internal bool CanRevertState { get; set; } = true; - private void OnIsCheckedChanged(bool? oldValue, bool? newValue) - { - // This workaround can be removed if pooling is removed. See https://github.com/unoplatform/uno/issues/12189 - if (_suppressCheckedChanged) - { - return; - } - - if (IsChecked == null) - { - // Indeterminate - Indeterminate?.Invoke(this, new RoutedEventArgs(this)); - } - else if (IsChecked.Value) - { - // Checked - Checked?.Invoke(this, new RoutedEventArgs(this)); - } - else - { - // Unchecked - Unchecked?.Invoke(this, new RoutedEventArgs(this)); - } - } - public void OnTemplateRecycled() { try From 87064ecda832a2ff616d2d55133e950fb3d129b4 Mon Sep 17 00:00:00 2001 From: Youssef Victor Date: Fri, 12 May 2023 14:35:12 +0300 Subject: [PATCH 3/3] chore: UpdatePackageDiffIgnore --- build/PackageDiffIgnore.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/PackageDiffIgnore.xml b/build/PackageDiffIgnore.xml index b91607e5ff6a..12dfa4076c5f 100644 --- a/build/PackageDiffIgnore.xml +++ b/build/PackageDiffIgnore.xml @@ -1243,7 +1243,7 @@ - +