Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking change] Remove legacy templated parent in Uno 6 #18672

Open
Tracked by #8339
Youssef1313 opened this issue Nov 3, 2024 · 2 comments
Open
Tracked by #8339

[Breaking change] Remove legacy templated parent in Uno 6 #18672

Youssef1313 opened this issue Nov 3, 2024 · 2 comments
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/breaking-change 💥 Categorizes an issue or PR as requiring a breaking change to be fixed. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

What would you like to be added

@Xiaoy312 Is the legacy templated parent code is intended to be removed in Uno 6?

In that case, that should be tracked in #8339

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/breaking-change 💥 Categorizes an issue or PR as requiring a breaking change to be fixed. labels Nov 3, 2024
@Xiaoy312
Copy link
Contributor

@jeromelaban we should be able to safely remove the now obsolete legacy TemplatedParent dp with uno6, right?
but what about the codegen? do we keep that in the temporarypermanent solution of DOStoreGenerator, or move it to DOGenerator as initially planned?

@jeromelaban
Copy link
Member

Yes, we'll remove that in the next build. As for the DOStore, if there's a performance impact, we could change it for the fastest one. We'll advise at that time.

@Youssef1313 Youssef1313 mentioned this issue Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/breaking-change 💥 Categorizes an issue or PR as requiring a breaking change to be fixed. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xiaoy312 @jeromelaban @Youssef1313