Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android, iOS] Adjust NativeFramePresenter to be compatible with UseWinUIBehavior = true #18461

Open
MartinZikmund opened this issue Oct 14, 2024 · 1 comment
Open

[Android, iOS] Adjust NativeFramePresenter to be compatible with UseWinUIBehavior = true #18461

MartinZikmund opened this issue Oct 14, 2024 · 1 comment
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...)

Comments

@MartinZikmund
Copy link
Member

What would you like to be added

The feature flag FeatureConfiguration.Frame.UseWinUIBehavior allows matching the exact Frame behavior with WinUI. However, the NativeFramePresenter on Android and iOS is currently not compatible with this behavior as it maintains internal page cache, whereas WinUI Frame handles the caching itself in a more custom way.

It should be possible to apply the native page transitions and back stack handling correctly, but with more significant changes to the implementation on both targets.

Why is this needed

Native frame compatibility

For which platform

Android, iOS

Anything else we need to know?

No response
@MartinZikmund MartinZikmund added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...) and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 14, 2024
@MartinZikmund MartinZikmund changed the title Adjust NativeFramePresenter to be compatible with UseWinUIBehavior = true [Android, iOS] Adjust NativeFramePresenter to be compatible with UseWinUIBehavior = true Oct 14, 2024
@MartinZikmund MartinZikmund added the difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI label Oct 14, 2024
@ramezgerges
Copy link
Contributor

#19094 should fix this for Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/navigation-lifecycle 🧬 Categorizes an issue or PR as relevant to the navigation and lifecycle (NavigationView, AppBar, ...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinZikmund @ramezgerges