[Breaking] fix: Drop Fluent V1 styles #14769
Conversation
This change drops the Fluent V1 styles in a non-breaking manner by redirecting them to the V2 styles. Later we will be able to drop the versioned styles altogether
github-actions
bot
added
the
area/code-generation
|
If I didn't miss something, this should not be breaking (except for behavior breaking, but I doubt any app is still using the old styles anyway):
As part of breaking changes we can then safely drop the whole version separation and just keep |
|
🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14769/index.html |
| #endif | ||
| break; | ||
| // As Fluent Styles V1 are no longer officially supported, prefer V2 styles. | ||
| requestedVersion = MaxSupportedResourcesVersion; |
There was a problem hiding this comment.
Is this variable used anymore?
|
This might still be breaking for UWP apps, particularly if resources don't match between versions. Building those styles are not impacting the build time that much, and we should not breaking in 5.x. |
MartinZikmund
changed the title
|
Closing for now until breaking changes are addressed |
GitHub Issue (If applicable): part of #14765
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fluent V1 is no longer supported and is buggy.
What is the new behavior?
Drop v1 styles in non-breaking manner.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.