Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TabView to latest MUX sources #10576

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Nov 25, 2022

Waiting for #12239

GitHub Issue (If applicable): related to #9730

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Nov 25, 2022

@MartinZikmund MartinZikmund self-assigned this Nov 26, 2022
@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from a78312e to cc3d6da Compare December 5, 2022 15:16
@MartinZikmund MartinZikmund marked this pull request as ready for review December 5, 2022 16:48
Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from 7a35560 to b96fb57 Compare December 21, 2022 13:31
@jeromelaban
Copy link
Member

@MartinZikmund is this PR still valid?

@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from b96fb57 to 269d327 Compare May 8, 2023 10:04
@MartinZikmund
Copy link
Member Author

@MartinZikmund is this PR still valid?

Finalizing it now

@github-actions github-actions bot added kind/documentation area/automation Categorizes an issue or PR as relevant to project automation labels May 8, 2023
@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from 1414b67 to a2d9dab Compare May 8, 2023 10:33
@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from 4c9462c to e26636d Compare May 10, 2023 19:09
@jeromelaban
Copy link
Member

@MartinZikmund There are two tests not passing on android.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from 6b14d4d to 29579a3 Compare September 20, 2023 06:39
@@ -106,6 +106,8 @@ public partial class AutomationPeer : DependencyObject

public AutomationPeer GetLabeledBy() => GetLabeledByCore();

protected internal IRawElementProviderSimple ProviderFromPeer(AutomationPeer peer) => new IRawElementProviderSimple(peer);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinZikmund The method is redefined in the same file. Could you fix that and see if this will get green?

@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from 29579a3 to 3ae4017 Compare September 26, 2023 11:41
@jeromelaban
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jeromelaban jeromelaban marked this pull request as draft December 12, 2023 03:49
auto-merge was automatically disabled December 12, 2023 03:49

Pull request was converted to draft

@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from 3480994 to 21dbe4f Compare October 22, 2024 11:58
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10576/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/tabview-upgrade branch from 0374eba to 295e99c Compare December 26, 2024 17:36
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-10576/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation kind/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants