[WIP] feat: Basic keyboard events support on Android #10387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
platform/android 🤖
jeromelaban
reviewed
Nov 14, 2022
| @@ -48,7 +48,7 @@ public static VirtualKey FromKeyCode(UIKeyboardHidUsage keyCode) | |||
| UIKeyboardHidUsage.KeyboardZ => VirtualKey.Z, | |||
|
|
|||
| UIKeyboardHidUsage.KeyboardPeriod => VirtualKey.Decimal, | |||
| UIKeyboardHidUsage.KeyboardEqualSign => VirtualKey.Enter, | |||
| UIKeyboardHidUsage.KeyboardEqualSign => VirtualKey.Enter, // TODO: THIS IS NOT CORRECT | |||
MartinZikmund
changed the title
MartinZikmund
force-pushed
the
dev/mazi/android-keyboard
branch
from
995312e to
8de962e
Compare
MartinZikmund
force-pushed
the
dev/mazi/android-keyboard
branch
from
23fd7d2 to
264c81a
Compare
github-actions
bot
added
the
area/automation
MartinZikmund
force-pushed
the
dev/mazi/android-keyboard
branch
2 times, most recently
from
bf3a832 to
a95eea3
Compare
MartinZikmund
force-pushed
the
dev/mazi/android-keyboard
branch
from
a95eea3 to
cb4082c
Compare
MartinZikmund
changed the title
|
Not up to date anymore, but can be reworked again on the latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #13983
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):