[Build] Validate Package ReferenceAPI Failed

[workgroupengineering]

Current behavior

When compiling PR #7830, API validation fails because I have added private ctor in BitmapEncoder.

I have added ignore to PackageDiffIgnore.xml but it fails because ValidatePackageReferenceAPI does not use it.

uno/build/Uno.UI.Build.csproj

Lines 440 to 457 in 58809ef

	<Target Name="ValidatePackage" AfterTargets="BuildNuGetPackage" Condition="'$(BuildingInsideVisualStudio)'=='' and '$(UNO_UWP_BUILD)'=='true'">
	<PropertyGroup>
	<PackageNamePrefix>Uno.WinUI</PackageNamePrefix>
	<PackageNamePrefix Condition="'$(UNO_UWP_BUILD)'=='true'">Uno.UI</PackageNamePrefix>
	</PropertyGroup>
	<Exec Command="dotnet tool install --tool-path $(MSBuildThisFileDirectory)\tools Uno.PackageDiff --version 1.0.0-dev.36" IgnoreExitCode="true" />
	<Exec Command="$(MSBuildThisFileDirectory)\tools\generatepkgdiff.exe --base=$(PackageNamePrefix) --other=$(PackageNamePrefix).$(GITVERSION_SemVer).nupkg --diffignore=PackageDiffIgnore.xml --outfile=$(OutputDir)\ApiDiff.$(GITVERSION_SemVer).md" />
	</Target>
	<Target Name="ValidatePackageReferenceAPI" AfterTargets="BuildNuGetPackage">
	<PropertyGroup>
	<PackageNamePrefix>Uno.WinUI</PackageNamePrefix>
	<PackageNamePrefix Condition="'$(UNO_UWP_BUILD)'=='true'">Uno.UI</PackageNamePrefix>
	</PropertyGroup>
	<Exec Command="dotnet $(MSBuildThisFileDirectory)..\src\Uno.ReferenceImplComparer\bin\Release\Uno.ReferenceImplComparer.dll $(MSBuildThisFileDirectory)$(PackageNamePrefix).$(GITVERSION_SemVer).nupkg" />
	</Target>

My questions are:

• Why double check the API(see above)?
• Can ValidatePackageReferenceAPI Target be removed?

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

No response

Environment

Other

NuGet package version(s)

master 58809ef

Affected platforms

Build tasks

IDE

Visual Studio 2022

IDE version

17.1.0 Preview 1.1

Relevant plugins

No response

Anything else we need to know?

No response

[jeromelaban]

No, the ValidatePackageReferenceAPI target cannot be removed as it ensure that the reference API matches actual platform implementations. Failing to align the targets will cause either runtime issues, or linker issues. If you removed the target in your PR, restore it and show the error in the PR, we can discuss it there.