Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(unlock-app): Improve localStorage usage #15361

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Jan 6, 2025

This PR introduces improvements to how we handle localStorage.

@0xTxbi 0xTxbi requested a review from julien51 January 6, 2025 10:56
@cla-bot cla-bot bot added the cla-signed label Jan 6, 2025
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Jan 8, 2025 0:13am
unlock-storybook ⬜️ Ignored (Inspect) Jan 8, 2025 0:13am

@0xTxbi 0xTxbi changed the title Revert "refactor(unlock-app): simplified our use of localStorage" feature(unlock-app): Improve localStorage usage Jan 6, 2025
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xTxbi 0xTxbi merged commit 44a3990 into master Jan 8, 2025
16 checks passed
@0xTxbi 0xTxbi deleted the revert-15288-localstorage-refactor branch January 8, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants