Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion about Lineages in Rust implementation of the API #40

Open
pverscha opened this issue Aug 19, 2024 · 0 comments
Open

Confusion about Lineages in Rust implementation of the API #40

pverscha opened this issue Aug 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pverscha
Copy link
Member

I've started working with the new Rust implementation of the Unipept API and I've stumbled upon some confusing names that are given to structs and enums. There are two different structs that are both called Lineage. One is defined in the LineageStore, the other one is defined by a macro in LineageHelper. I think we can rename the one in LineageStore to Rank, but we should discuss this.
@pverscha pverscha added the enhancement New feature or request label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pverscha