Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Convert all patches to mail-formatted patches #16

Open
kubanrob opened this issue Oct 25, 2022 · 0 comments
Open

Proposal: Convert all patches to mail-formatted patches #16

kubanrob opened this issue Oct 25, 2022 · 0 comments

Comments

@kubanrob
Copy link
Contributor

Editing or updating patches in the patch directory is unnecessarily hard, especially if a patch somewhere in the middle should to be added or updated.

It would be much easier if the patches would be mail-formatted (some of them already are).

That way, you could:

  1. checkout the appropriate musl version ( currently v1.1.19)
  2. apply the patches to the musl git repository (git am)
  3. make the changes to the git history
  4. export the new versions with git format-patch v1.1.19

Currently, a similar workflow is possible by manually applying non-mail-formatted patches with git apply and then committing each of these changes. However, converting back to the original patch format is unnecessarily hard.

Other points to consider:

  • Applying the patches into a git repository is also a useful tool for reviewing the patches.
  • The mail-formatted patches are already handled well by the Unikraft build system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant