Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Thai_graphclust_exclusive_model4_heavy #9

Open
FrankYFTang opened this issue Jan 22, 2021 · 1 comment
Open

Missing Thai_graphclust_exclusive_model4_heavy #9

FrankYFTang opened this issue Jan 22, 2021 · 1 comment

Comments

@FrankYFTang
Copy link
Collaborator

In ICU4X, we have a Thai_graphclust_exclusive_model4_heavy model in https://github.com/unicode-org/icu4x/blob/master/experimental/segmenter_lstm/tests/testdata/Thai_graphclust_exclusive_model4_heavy

but this model is not checked in under https://github.com/unicode-org/lstm_word_segmentation/tree/master/Models

@SahandFarhoodi
Copy link
Collaborator

You are right, this is an error. By looking at weights.json file, I can tell that name of the model in ICU4X should be Thai_graphclust_model4_heavy and we shouldn't have exclusive in the name, because I have grapheme clusters that are not Thai-specific in the dictionary there, such as space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants