Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Harden cross-domain policy #1

Open
ghost opened this issue Mar 14, 2018 · 1 comment
Open

Harden cross-domain policy #1

ghost opened this issue Mar 14, 2018 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Mar 14, 2018

Right now, Access-Control-Allow-Origin is set to * (see https://github.com/ungdev/Gala-api/blob/master/server.js#L27). Thus, it allows any JavaScript code in any domain to perform requests to Gala-api, while there is no need for it. The * should be replaced by a trusted domain (localhost during development, etc).
In addition, the header Vary: Origin should be added to prevent any risky sever-side caching.

@ghost ghost added the security label Mar 14, 2018
@arnaud9145
Copy link
Member

Je regarde ça ce soir, je dois avouer que je ne sais pas exactement à quoi sert ce paramètre... Sans lui par contre je n'arrivais pas à contacter le serveur depuis l'application. Par quoi devrais-je remplacer ça ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant