Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential issue: babel-eslint dependency #47

Open
yndajas opened this issue Jun 6, 2022 · 0 comments
Open

potential issue: babel-eslint dependency #47

yndajas opened this issue Jun 6, 2022 · 0 comments

Comments

@yndajas
Copy link

yndajas commented Jun 6, 2022

In https://github.com/unepwcmc/restoration-marketplace/pull/27, in order to use the local version of the component library and successfully run the webpack dev server (with yarn dev), the babel-eslint dependency needed moving out of devDependencies and into the main dependencies section before running yarn build-lib. Without doing this, webpack said it couldn't find the babel-eslint module and errored out

In my case the dist folder had already been generated and needed deleting before rerunning yarn build-lib after the dependency change - yarn build-lib didn't seem to bring in the missing package without fully deleting the dist folder and rebuilding from scratch. May have also needed to delete node_modules and rerun yarn install between the dependency change and yarn build-lib

Comment in PR linked above regarding this: https://github.com/unepwcmc/restoration-marketplace/pull/27#issuecomment-1147641142

@yndajas yndajas changed the title possible issue: babel-eslint dependency potential issue: babel-eslint dependency Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant