Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible wrong order when selected ECMWF source #84

Open
Skealz opened this issue Oct 21, 2024 · 0 comments
Open

Possible wrong order when selected ECMWF source #84

Skealz opened this issue Oct 21, 2024 · 0 comments
Assignees

Comments

@Skealz
Copy link
Collaborator

Skealz commented Oct 21, 2024

In https://github.com/umr-lops/grdwindinversion/blob/main/grdwindinversion/inversion.py#L142

for ecmwf_name in ['ecmwf_0125_1h', 'ecmwf_0100_1h']:

Hence, the 'ecmwf_0125_1h' is tried first (and is selected if exists), but the source ecmwf_0100_1h seems to be more recent (and more precise) so it should be used. To be confirmed.

It is not that a big deal because it seems both doesn't cover the same period of time (seems to have a small overlap only).

@vincelhx vincelhx self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants