Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: __serializeForclipboard These parameter types cannot be obtained #5996

Closed
1 task done
JS-mark opened this issue Jan 7, 2025 · 7 comments
Closed
1 task done
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@JS-mark
Copy link

JS-mark commented Jan 7, 2025

Affected Packages

pm

Version(s)

2.11.0

Bug Description

__serializeForclipboard These parameter types cannot be obtained

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

__serializeForclipboard These parameter types cannot be obtained;
Expected types can be exported externally
Recommended use export * from 'export * from 'prosemirror-view/src/index'

Additional Context (Optional)

No response

Dependency Updates

  • Yes, I've updated all my dependencies.
@JS-mark JS-mark added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Jan 7, 2025
@nperez0111
Copy link
Contributor

You will need to add more info here to what you are talking about

@JS-mark
Copy link
Author

JS-mark commented Jan 7, 2025

image
like this

@nperez0111
Copy link
Contributor

It is not actually exported by the prosemirror-view library, that is why it does not work

@nperez0111
Copy link
Contributor

It is marked as @internal:

// Exported for testing
import {serializeForClipboard, parseFromClipboard} from "./clipboard"
import {endComposition} from "./input"
/// @internal
export const __serializeForClipboard = serializeForClipboard
/// @internal
export const __parseFromClipboard = parseFromClipboard
/// @internal
export const __endComposition = endComposition

@JS-mark
Copy link
Author

JS-mark commented Jan 7, 2025

image
I understand, but it confused developers who use ts, because we use a private api

@nperez0111
Copy link
Contributor

This is not our concern though, we are not going to make this API public & have no way of doing it. even re-exporting the src directory's version would not fix that in the source it is marked as internal so TS will complain.

You can add it back to TS using declare module 'prosemirror-view' or upstream this to prosemirror to have it marked as not internal there. There is nothing we can do here

@JS-mark
Copy link
Author

JS-mark commented Jan 7, 2025

ok thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants