Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: useLayoutEffect ssr react warning #5872

Closed
1 task done
frattaro opened this issue Nov 26, 2024 · 2 comments
Closed
1 task done

[Bug]: useLayoutEffect ssr react warning #5872

frattaro opened this issue Nov 26, 2024 · 2 comments
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@frattaro
Copy link

Affected Packages

react

Version(s)

latest

Bug Description

The latest version of tiptap uses useLayoutEffect, and in an ssr site react throws hundreds of warnings about using useLayoutEffect on ssr. Can you use useIsomorphicLayoutEffect?

image

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

avoid the warnings if possible. they're dumb warnings and people have complained to the react team about them but they haven't done anything

Additional Context (Optional)

No response

Dependency Updates

  • Yes, I've updated all my dependencies.
@frattaro frattaro added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Nov 26, 2024
@nperez0111
Copy link
Contributor

Ah, fair. Yea I can

nperez0111 added a commit that referenced this issue Nov 26, 2024
@nperez0111
fix(react): useIsomorphicLayoutEffect instead to support SSR #5872
8e1a179
@nperez0111 nperez0111 mentioned this issue Nov 26, 2024
Merged
5 tasks
nperez0111 added a commit that referenced this issue Nov 26, 2024
@nperez0111
fix(react): useIsomorphicLayoutEffect instead to support SSR #5872
5d7573b
@nperez0111
Copy link
Contributor

v2.10.3 resolves this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nperez0111 @frattaro