From c50eb4bc2b1ce087bfb9958600d33b8ed7611bb4 Mon Sep 17 00:00:00 2001
From: Julien Cigar <julien@perdition.city>
Date: Mon, 4 Nov 2024 11:04:58 +0100
Subject: [PATCH 01/17] fix(core): handle selections better for
 `updateAttributes` (#5738)

---
 .changeset/swift-keys-collect.md              |  5 ++
 .../core/src/commands/updateAttributes.ts     | 84 ++++++++++++++++---
 2 files changed, 77 insertions(+), 12 deletions(-)
 create mode 100644 .changeset/swift-keys-collect.md

diff --git a/.changeset/swift-keys-collect.md b/.changeset/swift-keys-collect.md
new file mode 100644
index 00000000000..d9a6ebf459b
--- /dev/null
+++ b/.changeset/swift-keys-collect.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/core": patch
+---
+
+Improve handling of selections with `updateAttributes`. Should no longer modify parent nodes of the same type.
diff --git a/packages/core/src/commands/updateAttributes.ts b/packages/core/src/commands/updateAttributes.ts
index d6993b6d65f..f01fb1a750d 100644
--- a/packages/core/src/commands/updateAttributes.ts
+++ b/packages/core/src/commands/updateAttributes.ts
@@ -1,4 +1,7 @@
-import { MarkType, NodeType } from '@tiptap/pm/model'
+import {
+  Mark, MarkType, Node, NodeType,
+} from '@tiptap/pm/model'
+import { SelectionRange } from '@tiptap/pm/state'
 
 import { getMarkType } from '../helpers/getMarkType.js'
 import { getNodeType } from '../helpers/getNodeType.js'
@@ -30,6 +33,7 @@ declare module '@tiptap/core' {
 }
 
 export const updateAttributes: RawCommands['updateAttributes'] = (typeOrName, attributes = {}) => ({ tr, state, dispatch }) => {
+
   let nodeType: NodeType | null = null
   let markType: MarkType | null = null
 
@@ -51,24 +55,80 @@ export const updateAttributes: RawCommands['updateAttributes'] = (typeOrName, at
   }
 
   if (dispatch) {
-    tr.selection.ranges.forEach(range => {
+    tr.selection.ranges.forEach((range: SelectionRange) => {
+
       const from = range.$from.pos
       const to = range.$to.pos
 
-      state.doc.nodesBetween(from, to, (node, pos) => {
-        if (nodeType && nodeType === node.type) {
-          tr.setNodeMarkup(pos, undefined, {
-            ...node.attrs,
+      let lastPos: number | undefined
+      let lastNode: Node | undefined
+      let trimmedFrom: number
+      let trimmedTo: number
+
+      if (tr.selection.empty) {
+        state.doc.nodesBetween(from, to, (node: Node, pos: number) => {
+
+          if (nodeType && nodeType === node.type) {
+            trimmedFrom = Math.max(pos, from)
+            trimmedTo = Math.min(pos + node.nodeSize, to)
+            lastPos = pos
+            lastNode = node
+          }
+        })
+      } else {
+        state.doc.nodesBetween(from, to, (node: Node, pos: number) => {
+
+          if (pos < from && nodeType && nodeType === node.type) {
+            trimmedFrom = Math.max(pos, from)
+            trimmedTo = Math.min(pos + node.nodeSize, to)
+            lastPos = pos
+            lastNode = node
+          }
+
+          if (pos >= from && pos <= to) {
+
+            if (nodeType && nodeType === node.type) {
+              tr.setNodeMarkup(pos, undefined, {
+                ...node.attrs,
+                ...attributes,
+              })
+            }
+
+            if (markType && node.marks.length) {
+              node.marks.forEach((mark: Mark) => {
+
+                if (markType === mark.type) {
+                  const trimmedFrom2 = Math.max(pos, from)
+                  const trimmedTo2 = Math.min(pos + node.nodeSize, to)
+
+                  tr.addMark(
+                    trimmedFrom2,
+                    trimmedTo2,
+                    markType.create({
+                      ...mark.attrs,
+                      ...attributes,
+                    }),
+                  )
+                }
+              })
+            }
+          }
+        })
+      }
+
+      if (lastNode) {
+
+        if (lastPos !== undefined) {
+          tr.setNodeMarkup(lastPos, undefined, {
+            ...lastNode.attrs,
             ...attributes,
           })
         }
 
-        if (markType && node.marks.length) {
-          node.marks.forEach(mark => {
-            if (markType === mark.type) {
-              const trimmedFrom = Math.max(pos, from)
-              const trimmedTo = Math.min(pos + node.nodeSize, to)
+        if (markType && lastNode.marks.length) {
+          lastNode.marks.forEach((mark: Mark) => {
 
+            if (markType === mark.type) {
               tr.addMark(
                 trimmedFrom,
                 trimmedTo,
@@ -80,7 +140,7 @@ export const updateAttributes: RawCommands['updateAttributes'] = (typeOrName, at
             }
           })
         }
-      })
+      }
     })
   }
 

From 830e683ddeb6094acc7131b212aba8016c1112d3 Mon Sep 17 00:00:00 2001
From: Alan Poulain <contact@alanpoulain.eu>
Date: Mon, 4 Nov 2024 11:16:05 +0100
Subject: [PATCH 02/17] fix(bubble-menu): add `element` to `shouldShow` in
 BubbleMenu opts (#5790)

---
 .changeset/five-mice-turn.md                             | 5 +++++
 packages/extension-bubble-menu/src/bubble-menu-plugin.ts | 2 ++
 2 files changed, 7 insertions(+)
 create mode 100644 .changeset/five-mice-turn.md

diff --git a/.changeset/five-mice-turn.md b/.changeset/five-mice-turn.md
new file mode 100644
index 00000000000..a7f0aa1aa6d
--- /dev/null
+++ b/.changeset/five-mice-turn.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/extension-bubble-menu": patch
+---
+
+Add `element: HTMLElement` to `shouldShow` options within the BubbleMenu options.
diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts
index 4b8f8d9800c..1bcfe71097c 100644
--- a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts
+++ b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts
@@ -46,6 +46,7 @@ export interface BubbleMenuPluginProps {
   shouldShow?:
     | ((props: {
         editor: Editor
+        element: HTMLElement
         view: EditorView
         state: EditorState
         oldState?: EditorState
@@ -238,6 +239,7 @@ export class BubbleMenuView {
 
     const shouldShow = this.shouldShow?.({
       editor: this.editor,
+      element: this.element,
       view,
       state,
       oldState,

From e5228ea6be571bcde7b72c824c8085a4717c71b5 Mon Sep 17 00:00:00 2001
From: Nick Perez <nicholas.perez@tiptap.dev>
Date: Mon, 4 Nov 2024 13:49:58 +0100
Subject: [PATCH 03/17] feat: accessibility improvements (#5758)

---
 packages/core/src/Editor.ts | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/packages/core/src/Editor.ts b/packages/core/src/Editor.ts
index f7cddb7238e..d3378a47b0d 100644
--- a/packages/core/src/Editor.ts
+++ b/packages/core/src/Editor.ts
@@ -360,6 +360,11 @@ export class Editor extends EventEmitter<EditorEvents> {
 
     this.view = new EditorView(this.options.element, {
       ...this.options.editorProps,
+      attributes: {
+        // add `role="textbox"` to the editor element
+        role: 'textbox',
+        ...this.options.editorProps?.attributes,
+      },
       dispatchTransaction: this.dispatchTransaction.bind(this),
       state: EditorState.create({
         doc,
@@ -367,14 +372,6 @@ export class Editor extends EventEmitter<EditorEvents> {
       }),
     })
 
-    // add `role="textbox"` to the editor element
-    this.view.dom.setAttribute('role', 'textbox')
-
-    // add aria-label to the editor element
-    if (!this.view.dom.getAttribute('aria-label')) {
-      this.view.dom.setAttribute('aria-label', 'Rich-Text Editor')
-    }
-
     // `editor.view` is not yet available at this time.
     // Therefore we will add all plugins and node views directly afterwards.
     const newState = this.state.reconfigure({

From ddd3d713e576d2ad80540d58ae0e9dc9fc0a5f76 Mon Sep 17 00:00:00 2001
From: Nick Perez <nicholas.perez@tiptap.dev>
Date: Wed, 6 Nov 2024 12:48:37 +0100
Subject: [PATCH 04/17] fix(react): allow react 19 (#5807)

---
 .changeset/polite-buttons-wash.md | 5 +++++
 package-lock.json                 | 4 ++--
 packages/react/package.json       | 4 ++--
 3 files changed, 9 insertions(+), 4 deletions(-)
 create mode 100644 .changeset/polite-buttons-wash.md

diff --git a/.changeset/polite-buttons-wash.md b/.changeset/polite-buttons-wash.md
new file mode 100644
index 00000000000..69aa677ea1c
--- /dev/null
+++ b/.changeset/polite-buttons-wash.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/react": patch
+---
+
+React 19 is now allowed as a peer dep, we did not have to make any changes for React 19
diff --git a/package-lock.json b/package-lock.json
index 082a62505d7..f210c38cba6 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -19762,8 +19762,8 @@
       "peerDependencies": {
         "@tiptap/core": "^2.7.0",
         "@tiptap/pm": "^2.7.0",
-        "react": "^17.0.0 || ^18.0.0",
-        "react-dom": "^17.0.0 || ^18.0.0"
+        "react": "^17.0.0 || ^18.0.0 || ^19.0.0",
+        "react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0"
       }
     },
     "packages/starter-kit": {
diff --git a/packages/react/package.json b/packages/react/package.json
index 350739d702a..38647da7e35 100644
--- a/packages/react/package.json
+++ b/packages/react/package.json
@@ -46,8 +46,8 @@
   "peerDependencies": {
     "@tiptap/core": "^2.7.0",
     "@tiptap/pm": "^2.7.0",
-    "react": "^17.0.0 || ^18.0.0",
-    "react-dom": "^17.0.0 || ^18.0.0"
+    "react": "^17.0.0 || ^18.0.0 || ^19.0.0",
+    "react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0"
   },
   "repository": {
     "type": "git",

From 5a04885b9413a87b2f2e6fd41868e95d18e29ea6 Mon Sep 17 00:00:00 2001
From: solvsoft <41623271+solvsoft@users.noreply.github.com>
Date: Wed, 6 Nov 2024 13:00:40 +0100
Subject: [PATCH 05/17] fix(vue): pin vue-ts-types version (#5800)

---
 packages/vue-2/package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/vue-2/package.json b/packages/vue-2/package.json
index 995e50341e1..8d47a705e15 100644
--- a/packages/vue-2/package.json
+++ b/packages/vue-2/package.json
@@ -31,7 +31,7 @@
   "dependencies": {
     "@tiptap/extension-bubble-menu": "^2.9.1",
     "@tiptap/extension-floating-menu": "^2.9.1",
-    "vue-ts-types": "^1.6.0"
+    "vue-ts-types": "1.6.2"
   },
   "devDependencies": {
     "@tiptap/core": "^2.9.1",

From 4ee59c1f7d0aa8dcfea013ff4378bf1cd8d7eeb9 Mon Sep 17 00:00:00 2001
From: Nick the Sick <nicholas.perez@tiptap.dev>
Date: Wed, 6 Nov 2024 13:01:37 +0100
Subject: [PATCH 06/17] chore: add changeset & package-lock

---
 .changeset/mean-moose-bow.md | 5 +++++
 package-lock.json            | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/mean-moose-bow.md

diff --git a/.changeset/mean-moose-bow.md b/.changeset/mean-moose-bow.md
new file mode 100644
index 00000000000..6598c1e0e30
--- /dev/null
+++ b/.changeset/mean-moose-bow.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/vue-2": patch
+---
+
+Pin vue-ts-types to a working version for vue-2
diff --git a/package-lock.json b/package-lock.json
index f210c38cba6..bf66efc1bb9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -19822,7 +19822,7 @@
       "dependencies": {
         "@tiptap/extension-bubble-menu": "^2.9.1",
         "@tiptap/extension-floating-menu": "^2.9.1",
-        "vue-ts-types": "^1.6.0"
+        "vue-ts-types": "1.6.2"
       },
       "devDependencies": {
         "@tiptap/core": "^2.9.1",

From 444e6e5a11d6c323cd298aa5106fc168a83640e8 Mon Sep 17 00:00:00 2001
From: Armando Guarino <arm.guarino@gmail.com>
Date: Wed, 6 Nov 2024 13:42:27 +0100
Subject: [PATCH 07/17] refactor: adjust validate and add shouldAutoLink to
 improve URL handling

---
 .changeset/witty-olives-protect.md            |  6 ++
 demos/src/Marks/Link/React/index.jsx          | 55 +++++++++++++++++++
 demos/src/Marks/Link/React/index.spec.js      | 42 +++++++++++---
 .../extension-link/src/helpers/autolink.ts    |  3 +
 packages/extension-link/src/link.ts           | 30 +++++++---
 5 files changed, 122 insertions(+), 14 deletions(-)
 create mode 100644 .changeset/witty-olives-protect.md

diff --git a/.changeset/witty-olives-protect.md b/.changeset/witty-olives-protect.md
new file mode 100644
index 00000000000..cb156c4bbb1
--- /dev/null
+++ b/.changeset/witty-olives-protect.md
@@ -0,0 +1,6 @@
+---
+"@tiptap/extension-link": patch
+"tiptap-demos": patch
+---
+
+Refactor validate and add shouldAutoLink function to improve URL handling
diff --git a/demos/src/Marks/Link/React/index.jsx b/demos/src/Marks/Link/React/index.jsx
index 452bb5b4bc2..72a153fea1f 100644
--- a/demos/src/Marks/Link/React/index.jsx
+++ b/demos/src/Marks/Link/React/index.jsx
@@ -20,6 +20,61 @@ export default () => {
         openOnClick: false,
         autolink: true,
         defaultProtocol: 'https',
+        protocols: ['http', 'https'],
+        validate: (url, ctx) => {
+          try {
+            // construct URL
+            const parsedUrl = url.startsWith('http') ? new URL(url) : new URL(`${ctx.defaultProtocol}://${url}`)
+
+            // use default validation
+            if (!ctx.defaultValidate(parsedUrl.href)) {
+              return false
+            }
+
+            // disallowed protocols
+            const disallowedProtocols = ['ftp', 'file', 'mailto']
+            const protocol = parsedUrl.protocol.replace(':', '')
+
+            if (disallowedProtocols.includes(protocol)) {
+              return false
+            }
+
+            // only allow protocols specified in ctx.protocols
+            const allowedProtocols = ctx.protocols.map(p => (typeof p === 'string' ? p : p.scheme))
+
+            if (!allowedProtocols.includes(protocol)) {
+              return false
+            }
+
+            // disallowed domains
+            const disallowedDomains = ['example-phishing.com', 'malicious-site.net']
+            const domain = parsedUrl.hostname
+
+            if (disallowedDomains.includes(domain)) {
+              return false
+            }
+
+            // all checks have passed
+            return true
+          } catch (error) {
+            return false
+          }
+        },
+        shouldAutoLink: url => {
+          try {
+            // construct URL
+            const parsedUrl = url.startsWith('http') ? new URL(url) : new URL(`https://${url}`)
+
+            // only auto-link if the domain is not in the disallowed list
+            const disallowedDomains = ['example-no-autolink.com', 'another-no-autolink.com']
+            const domain = parsedUrl.hostname
+
+            return !disallowedDomains.includes(domain)
+          } catch (error) {
+            return false
+          }
+        },
+
       }),
     ],
     content: `
diff --git a/demos/src/Marks/Link/React/index.spec.js b/demos/src/Marks/Link/React/index.spec.js
index 61fd1b281ff..bc13e1af8c7 100644
--- a/demos/src/Marks/Link/React/index.spec.js
+++ b/demos/src/Marks/Link/React/index.spec.js
@@ -12,27 +12,27 @@ context('/src/Marks/Link/React/', () => {
 
   it('should parse a tags correctly', () => {
     cy.get('.tiptap').then(([{ editor }]) => {
-      editor.commands.setContent('<p><a href="#">Example Text1</a></p>')
+      editor.commands.setContent('<p><a href="https://example.com">Example Text1</a></p>')
       expect(editor.getHTML()).to.eq(
-        '<p><a target="_blank" rel="noopener noreferrer nofollow" href="#">Example Text1</a></p>',
+        '<p><a target="_blank" rel="noopener noreferrer nofollow" href="https://example.com">Example Text1</a></p>',
       )
     })
   })
 
   it('should parse a tags with target attribute correctly', () => {
     cy.get('.tiptap').then(([{ editor }]) => {
-      editor.commands.setContent('<p><a href="#" target="_self">Example Text2</a></p>')
+      editor.commands.setContent('<p><a href="https://example.com" target="_self">Example Text2</a></p>')
       expect(editor.getHTML()).to.eq(
-        '<p><a target="_self" rel="noopener noreferrer nofollow" href="#">Example Text2</a></p>',
+        '<p><a target="_self" rel="noopener noreferrer nofollow" href="https://example.com">Example Text2</a></p>',
       )
     })
   })
 
   it('should parse a tags with rel attribute correctly', () => {
     cy.get('.tiptap').then(([{ editor }]) => {
-      editor.commands.setContent('<p><a href="#" rel="follow">Example Text3</a></p>')
+      editor.commands.setContent('<p><a href="https://example.com" rel="follow">Example Text3</a></p>')
       expect(editor.getHTML()).to.eq(
-        '<p><a target="_blank" rel="follow" href="#">Example Text3</a></p>',
+        '<p><a target="_blank" rel="follow" href="https://example.com">Example Text3</a></p>',
       )
     })
   })
@@ -54,7 +54,7 @@ context('/src/Marks/Link/React/', () => {
 
   it('should allow exiting the link once set', () => {
     cy.get('.tiptap').then(([{ editor }]) => {
-      editor.commands.setContent('<p><a href="#" target="_self">Example Text2</a></p>')
+      editor.commands.setContent('<p><a href="https://example.com" target="_self">Example Text2</a></p>')
       cy.get('.tiptap').type('{rightArrow}')
 
       cy.get('button:first').should('not.have.class', 'is-active')
@@ -129,4 +129,32 @@ context('/src/Marks/Link/React/', () => {
       .find('a[href="http://example3.com/foobar"]')
       .should('contain', 'http://example3.com/foobar')
   })
+
+  it('should not allow links with disallowed protocols', () => {
+    const disallowedProtocols = ['ftp://example.com', 'file:///example.txt', 'mailto:test@example.com']
+
+    disallowedProtocols.forEach(url => {
+      cy.get('.tiptap').then(([{ editor }]) => {
+        editor.commands.setContent(`<p><a href="${url}">Example Text</a></p>`)
+        expect(editor.getHTML()).to.not.include(`<a href="${url}">`)
+      })
+    })
+  })
+
+  it('should not allow links with disallowed domains', () => {
+    const disallowedDomains = ['https://example-phishing.com', 'https://malicious-site.net']
+
+    disallowedDomains.forEach(url => {
+      cy.get('.tiptap').then(([{ editor }]) => {
+        editor.commands.setContent(`<p><a href="${url}">Example Text</a></p>`)
+        expect(editor.getHTML()).to.not.include(`<a href="${url}">`)
+      })
+    })
+  })
+
+  it('should not auto-link a URL from a disallowed domain', () => {
+    cy.get('.tiptap').type('https://example-phishing.com ') // disallowed domain
+    cy.get('.tiptap').should('not.have.descendants', 'a')
+    cy.get('.tiptap').should('contain.text', 'https://example-phishing.com')
+  })
 })
diff --git a/packages/extension-link/src/helpers/autolink.ts b/packages/extension-link/src/helpers/autolink.ts
index c15efa9a17b..7b57007a5cd 100644
--- a/packages/extension-link/src/helpers/autolink.ts
+++ b/packages/extension-link/src/helpers/autolink.ts
@@ -35,6 +35,7 @@ type AutolinkOptions = {
   type: MarkType
   defaultProtocol: string
   validate: (url: string) => boolean
+  shouldAutoLink: (url: string) => boolean
 }
 
 /**
@@ -144,6 +145,8 @@ export function autolink(options: AutolinkOptions): Plugin {
             })
             // validate link
             .filter(link => options.validate(link.value))
+            // check whether should autolink
+            .filter(link => options.shouldAutoLink(link.value))
             // Add link mark.
             .forEach(link => {
               if (getMarksBetween(link.from, link.to, newState.doc).some(item => item.mark.type === options.type)) {
diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
index f78dc1db0b3..353e559799e 100644
--- a/packages/extension-link/src/link.ts
+++ b/packages/extension-link/src/link.ts
@@ -75,9 +75,21 @@ export interface LinkOptions {
   /**
    * A validation function that modifies link verification for the auto linker.
    * @param url - The url to be validated.
+   * @param ctx - An object containing:
+   *              - `defaultValidate`: A function that performs the default URL validation.
+   *              - `protocols`: An array of allowed protocols for the URL (e.g., "http", "https").
+   *              - `defaultProtocol`: A string that represents the default protocol (e.g. 'http')
    * @returns - True if the url is valid, false otherwise.
    */
-  validate: (url: string) => boolean
+  validate: (url: string, ctx: { defaultValidate: (url: string) => boolean, protocols: Array<LinkProtocolOptions | string>, defaultProtocol: string }) => boolean
+
+  /**
+   * Determines whether a valid link should be automatically linked in the content.
+   *
+   * @param url - The URL that has already been validated.
+   * @returns - True if the link should be auto-linked; false if it should not be auto-linked.
+   */
+  shouldAutoLink: (url: string) => boolean
 }
 
 declare module '@tiptap/core' {
@@ -169,7 +181,8 @@ export const Link = Mark.create<LinkOptions>({
         rel: 'noopener noreferrer nofollow',
         class: null,
       },
-      validate: url => !!url,
+      validate: (url, ctx) => !!isAllowedUri(url, ctx.protocols),
+      shouldAutoLink: url => !!url,
     }
   },
 
@@ -200,7 +213,7 @@ export const Link = Mark.create<LinkOptions>({
         const href = (dom as HTMLElement).getAttribute('href')
 
         // prevent XSS attacks
-        if (!href || !isAllowedUri(href, this.options.protocols)) {
+        if (!href || !this.options.validate(href, { defaultValidate: url => !!isAllowedUri(url, this.options.protocols), protocols: this.options.protocols, defaultProtocol: this.options.defaultProtocol })) {
           return false
         }
         return null
@@ -210,7 +223,7 @@ export const Link = Mark.create<LinkOptions>({
 
   renderHTML({ HTMLAttributes }) {
     // prevent XSS attacks
-    if (!isAllowedUri(HTMLAttributes.href, this.options.protocols)) {
+    if (!this.options.validate(HTMLAttributes.href, { defaultValidate: href => !!isAllowedUri(href, this.options.protocols), protocols: this.options.protocols, defaultProtocol: this.options.defaultProtocol })) {
       // strip out the href
       return ['a', mergeAttributes(this.options.HTMLAttributes, { ...HTMLAttributes, href: '' }), 0]
     }
@@ -250,8 +263,9 @@ export const Link = Mark.create<LinkOptions>({
           const foundLinks: PasteRuleMatch[] = []
 
           if (text) {
-            const { validate } = this.options
-            const links = find(text).filter(item => item.isLink && validate(item.value))
+            console.log(text)
+            const { validate, protocols, defaultProtocol } = this.options
+            const links = find(text).filter(item => item.isLink && validate(item.href, { defaultValidate: href => !!isAllowedUri(href, protocols), protocols, defaultProtocol }))
 
             if (links.length) {
               links.forEach(link => (foundLinks.push({
@@ -278,13 +292,15 @@ export const Link = Mark.create<LinkOptions>({
 
   addProseMirrorPlugins() {
     const plugins: Plugin[] = []
+    const { validate, protocols, defaultProtocol } = this.options
 
     if (this.options.autolink) {
       plugins.push(
         autolink({
           type: this.type,
           defaultProtocol: this.options.defaultProtocol,
-          validate: this.options.validate,
+          validate: url => validate(url, { defaultValidate: href => !!isAllowedUri(href, protocols), protocols, defaultProtocol }),
+          shouldAutoLink: this.options.shouldAutoLink,
         }),
       )
     }

From 6bdb5917a51ad59e4a7f1ecaf826cef02f30a009 Mon Sep 17 00:00:00 2001
From: Armando Guarino <arm.guarino@gmail.com>
Date: Wed, 6 Nov 2024 14:06:48 +0100
Subject: [PATCH 08/17] refactor: remove logs and fix typo

---
 packages/extension-link/src/link.ts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
index 353e559799e..738d588d00b 100644
--- a/packages/extension-link/src/link.ts
+++ b/packages/extension-link/src/link.ts
@@ -263,9 +263,8 @@ export const Link = Mark.create<LinkOptions>({
           const foundLinks: PasteRuleMatch[] = []
 
           if (text) {
-            console.log(text)
             const { validate, protocols, defaultProtocol } = this.options
-            const links = find(text).filter(item => item.isLink && validate(item.href, { defaultValidate: href => !!isAllowedUri(href, protocols), protocols, defaultProtocol }))
+            const links = find(text).filter(item => item.isLink && validate(item.value, { defaultValidate: href => !!isAllowedUri(href, protocols), protocols, defaultProtocol }))
 
             if (links.length) {
               links.forEach(link => (foundLinks.push({

From 035862b6985c8ced2b81c351393601ef6bd66d01 Mon Sep 17 00:00:00 2001
From: Armando Guarino <arm.guarino@gmail.com>
Date: Wed, 6 Nov 2024 14:11:48 +0100
Subject: [PATCH 09/17] refactor: update tests url checking logic and comments

---
 demos/src/Marks/Link/React/index.spec.js | 4 ++--
 packages/extension-link/src/link.ts      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/demos/src/Marks/Link/React/index.spec.js b/demos/src/Marks/Link/React/index.spec.js
index bc13e1af8c7..ea5bf905771 100644
--- a/demos/src/Marks/Link/React/index.spec.js
+++ b/demos/src/Marks/Link/React/index.spec.js
@@ -136,7 +136,7 @@ context('/src/Marks/Link/React/', () => {
     disallowedProtocols.forEach(url => {
       cy.get('.tiptap').then(([{ editor }]) => {
         editor.commands.setContent(`<p><a href="${url}">Example Text</a></p>`)
-        expect(editor.getHTML()).to.not.include(`<a href="${url}">`)
+        expect(editor.getHTML()).to.not.include(url)
       })
     })
   })
@@ -147,7 +147,7 @@ context('/src/Marks/Link/React/', () => {
     disallowedDomains.forEach(url => {
       cy.get('.tiptap').then(([{ editor }]) => {
         editor.commands.setContent(`<p><a href="${url}">Example Text</a></p>`)
-        expect(editor.getHTML()).to.not.include(`<a href="${url}">`)
+        expect(editor.getHTML()).to.not.include(url)
       })
     })
   })
diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
index 738d588d00b..f0500da541f 100644
--- a/packages/extension-link/src/link.ts
+++ b/packages/extension-link/src/link.ts
@@ -73,7 +73,7 @@ export interface LinkOptions {
   HTMLAttributes: Record<string, any>
 
   /**
-   * A validation function that modifies link verification for the auto linker.
+   * A validation function that modifies link verification.
    * @param url - The url to be validated.
    * @param ctx - An object containing:
    *              - `defaultValidate`: A function that performs the default URL validation.

From 6b8ce3778e952b7185ea57558f2b4a96a690658e Mon Sep 17 00:00:00 2001
From: Armando Guarino <arm.guarino@gmail.com>
Date: Wed, 6 Nov 2024 14:14:59 +0100
Subject: [PATCH 10/17] refactor: add jsdoc validate and shouldAutoLink comment

---
 packages/extension-link/src/link.ts | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
index f0500da541f..76368488219 100644
--- a/packages/extension-link/src/link.ts
+++ b/packages/extension-link/src/link.ts
@@ -74,20 +74,22 @@ export interface LinkOptions {
 
   /**
    * A validation function that modifies link verification.
-   * @param url - The url to be validated.
-   * @param ctx - An object containing:
-   *              - `defaultValidate`: A function that performs the default URL validation.
-   *              - `protocols`: An array of allowed protocols for the URL (e.g., "http", "https").
-   *              - `defaultProtocol`: A string that represents the default protocol (e.g. 'http')
-   * @returns - True if the url is valid, false otherwise.
+   *
+   * @param {string} url - The URL to be validated.
+   * @param {Object} ctx - An object containing:
+   * @param {Function} ctx.defaultValidate - A function that performs the default URL validation.
+   * @param {string[]} ctx.protocols - An array of allowed protocols for the URL (e.g., "http", "https").
+   * @param {string} ctx.defaultProtocol - A string that represents the default protocol (e.g., 'http').
+   *
+   * @returns {boolean} True if the URL is valid, false otherwise.
    */
   validate: (url: string, ctx: { defaultValidate: (url: string) => boolean, protocols: Array<LinkProtocolOptions | string>, defaultProtocol: string }) => boolean
 
   /**
    * Determines whether a valid link should be automatically linked in the content.
    *
-   * @param url - The URL that has already been validated.
-   * @returns - True if the link should be auto-linked; false if it should not be auto-linked.
+   * @param {string} url - The URL that has already been validated.
+   * @returns {boolean} - True if the link should be auto-linked; false if it should not be auto-linked.
    */
   shouldAutoLink: (url: string) => boolean
 }

From efac420c9f745c189a696ca424b544279dea7efb Mon Sep 17 00:00:00 2001
From: Armando Guarino <arm.guarino@gmail.com>
Date: Wed, 6 Nov 2024 14:16:39 +0100
Subject: [PATCH 11/17] chore: improve changeset description

---
 .changeset/witty-olives-protect.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.changeset/witty-olives-protect.md b/.changeset/witty-olives-protect.md
index cb156c4bbb1..0893a2fdef4 100644
--- a/.changeset/witty-olives-protect.md
+++ b/.changeset/witty-olives-protect.md
@@ -3,4 +3,4 @@
 "tiptap-demos": patch
 ---
 
-Refactor validate and add shouldAutoLink function to improve URL handling
+The link extension's `validate` option now applies to both auto-linking and XSS mitigation. While, the new `shouldAutoLink` option is used to disable auto linking on an otherwise valid url.

From 585f6ef77e9e02e98ef19313fffc535ed23ab52f Mon Sep 17 00:00:00 2001
From: Armando Guarino <arm.guarino@gmail.com>
Date: Wed, 6 Nov 2024 15:08:30 +0100
Subject: [PATCH 12/17] test: improve url parsing logic

---
 demos/src/Marks/Link/React/index.jsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/demos/src/Marks/Link/React/index.jsx b/demos/src/Marks/Link/React/index.jsx
index 72a153fea1f..d9a57661a30 100644
--- a/demos/src/Marks/Link/React/index.jsx
+++ b/demos/src/Marks/Link/React/index.jsx
@@ -24,7 +24,7 @@ export default () => {
         validate: (url, ctx) => {
           try {
             // construct URL
-            const parsedUrl = url.startsWith('http') ? new URL(url) : new URL(`${ctx.defaultProtocol}://${url}`)
+            const parsedUrl = url.includes(':') ? new URL(url) : new URL(`${ctx.defaultProtocol}://${url}`)
 
             // use default validation
             if (!ctx.defaultValidate(parsedUrl.href)) {
@@ -63,7 +63,7 @@ export default () => {
         shouldAutoLink: url => {
           try {
             // construct URL
-            const parsedUrl = url.startsWith('http') ? new URL(url) : new URL(`https://${url}`)
+            const parsedUrl = url.includes(':') ? new URL(url) : new URL(`https://${url}`)
 
             // only auto-link if the domain is not in the disallowed list
             const disallowedDomains = ['example-no-autolink.com', 'another-no-autolink.com']

From 94a8d258f8cd4549de24d11e2d591ba4363250e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89ric=20Le=20Ma=C3=AEtre?=
 <eric.erwan.le.maitre@gmail.com>
Date: Thu, 7 Nov 2024 09:19:46 +0100
Subject: [PATCH 13/17] fix(vue-3): on editor destruction, transition smoothly
 (#5772)

---
 .changeset/five-flowers-eat.md                |  5 ++
 CONTRIBUTING.md                               |  2 +-
 .../src/Examples/Transition/Vue/Extension.js  |  2 +-
 .../Transition/Vue/ParentComponent.vue        | 36 +++++++++++++++
 .../Vue/{Component.vue => VueComponent.vue}   |  0
 .../src/Examples/Transition/Vue/index.spec.js | 18 +++++---
 demos/src/Examples/Transition/Vue/index.vue   | 46 +++++++++++++++----
 packages/vue-3/src/EditorContent.ts           |  1 -
 packages/vue-3/src/useEditor.ts               |  6 +++
 9 files changed, 98 insertions(+), 18 deletions(-)
 create mode 100644 .changeset/five-flowers-eat.md
 create mode 100644 demos/src/Examples/Transition/Vue/ParentComponent.vue
 rename demos/src/Examples/Transition/Vue/{Component.vue => VueComponent.vue} (100%)

diff --git a/.changeset/five-flowers-eat.md b/.changeset/five-flowers-eat.md
new file mode 100644
index 00000000000..a44e7c58d8f
--- /dev/null
+++ b/.changeset/five-flowers-eat.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/vue-3": patch
+---
+
+Fix editor destruction before transition end if editor is nested
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 5a7ab416a06..e59b86f408a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -36,7 +36,7 @@ Before submitting a pull request:
 - Check the codebase to ensure that your feature doesn't already exist.
 - Check the pull requests to ensure that another person hasn't already submitted the feature or fix.
 
-Before commiting:
+Before committing:
 
 - Make sure to run the tests and linter before committing your changes.
 - If you are making changes to one of the packages, make sure to **always** include a [changeset](https://github.com/changesets/changesets) in your PR describing **what changed** with a **description** of the change. Those are responsible for changelog creation
diff --git a/demos/src/Examples/Transition/Vue/Extension.js b/demos/src/Examples/Transition/Vue/Extension.js
index 9dede7bb0d0..b83694ad721 100644
--- a/demos/src/Examples/Transition/Vue/Extension.js
+++ b/demos/src/Examples/Transition/Vue/Extension.js
@@ -1,7 +1,7 @@
 import { mergeAttributes, Node } from '@tiptap/core'
 import { VueNodeViewRenderer } from '@tiptap/vue-3'
 
-import Component from './Component.vue'
+import Component from './VueComponent.vue'
 
 export default Node.create({
   name: 'vueComponent',
diff --git a/demos/src/Examples/Transition/Vue/ParentComponent.vue b/demos/src/Examples/Transition/Vue/ParentComponent.vue
new file mode 100644
index 00000000000..7cebbc9a95b
--- /dev/null
+++ b/demos/src/Examples/Transition/Vue/ParentComponent.vue
@@ -0,0 +1,36 @@
+<template>
+  <div>
+    <EditorContent :editor="editor" />
+  </div>
+</template>
+
+<script setup lang="ts">
+import StarterKit from '@tiptap/starter-kit'
+import { EditorContent, useEditor } from '@tiptap/vue-3'
+import { ref } from 'vue'
+
+import VueComponent from './Extension.js'
+import type { TNote } from './types.js'
+
+const note = ref<TNote>({
+  id: 'note-1',
+  content: `
+  <p>Some random note text</p>
+  <vue-component count="0"></vue-component>
+  `,
+})
+
+const editor = useEditor({
+  content: note.value.content,
+  editorProps: {
+    attributes: {
+      class: 'textarea',
+    },
+  },
+  extensions: [
+    StarterKit,
+    VueComponent,
+  ],
+})
+
+</script>
diff --git a/demos/src/Examples/Transition/Vue/Component.vue b/demos/src/Examples/Transition/Vue/VueComponent.vue
similarity index 100%
rename from demos/src/Examples/Transition/Vue/Component.vue
rename to demos/src/Examples/Transition/Vue/VueComponent.vue
diff --git a/demos/src/Examples/Transition/Vue/index.spec.js b/demos/src/Examples/Transition/Vue/index.spec.js
index 5bceb87e198..39100317dfb 100644
--- a/demos/src/Examples/Transition/Vue/index.spec.js
+++ b/demos/src/Examples/Transition/Vue/index.spec.js
@@ -3,26 +3,30 @@ context('/src/Examples/Transition/Vue/', () => {
     cy.visit('/src/Examples/Transition/Vue/')
   })
 
-  it('should not have an active tiptap instance but a button', () => {
+  it('should have two buttons and no active tiptap instance', () => {
     cy.get('.tiptap').should('not.exist')
 
-    cy.get('#toggle-editor').should('exist')
+    cy.get('#toggle-direct-editor').should('exist')
+    cy.get('#toggle-nested-editor').should('exist')
   })
 
-  it('clicking the button should show the editor', () => {
-    cy.get('#toggle-editor').click()
+  it('clicking the buttons should show two editors', () => {
+    cy.get('#toggle-direct-editor').click()
+    cy.get('#toggle-nested-editor').click()
 
     cy.get('.tiptap').should('exist')
     cy.get('.tiptap').should('be.visible')
   })
 
-  it('clicking the button again should hide the editor', () => {
-    cy.get('#toggle-editor').click()
+  it('clicking the buttons again should hide the editors', () => {
+    cy.get('#toggle-direct-editor').click()
+    cy.get('#toggle-nested-editor').click()
 
     cy.get('.tiptap').should('exist')
     cy.get('.tiptap').should('be.visible')
 
-    cy.get('#toggle-editor').click()
+    cy.get('#toggle-direct-editor').click()
+    cy.get('#toggle-nested-editor').click()
 
     cy.get('.tiptap').should('not.exist')
   })
diff --git a/demos/src/Examples/Transition/Vue/index.vue b/demos/src/Examples/Transition/Vue/index.vue
index 46e65dc0c5b..6bd914949bc 100644
--- a/demos/src/Examples/Transition/Vue/index.vue
+++ b/demos/src/Examples/Transition/Vue/index.vue
@@ -1,12 +1,18 @@
 <script setup lang="ts">
-
 import StarterKit from '@tiptap/starter-kit'
 import { EditorContent, useEditor } from '@tiptap/vue-3'
 import { ref } from 'vue'
 
 import VueComponent from './Extension.js'
+import ParentComponent from './ParentComponent.vue'
 import type { TNote } from './types.js'
 
+/** Display editor in the same component */
+const showDirectEditor = ref(false)
+
+/** Display editor in a child component */
+const showNestedEditor = ref(false)
+
 const note = ref<TNote>({
   id: 'note-1',
   content: `
@@ -28,24 +34,43 @@ const editor = useEditor({
   ],
 })
 
-const showEditor = ref(false)
-
 </script>
 
 <template>
+  <!-- Transition with editor in the same component -->
   <div>
     <button
+      id="toggle-direct-editor"
       type="button"
-      @click="showEditor = !showEditor"
       style="margin-bottom: 1rem;"
-      id="toggle-editor"
+      @click="showDirectEditor = !showDirectEditor"
     >
-      {{ showEditor ? 'Hide editor' : 'Show editor' }}
+      {{ showDirectEditor ? 'Hide direct editor' : 'Show direct editor' }}
     </button>
 
     <transition name="fade">
-      <div v-if="showEditor" class="tiptap-wrapper">
-        <editor-content :editor="editor" />
+      <div v-if="showDirectEditor" class="tiptap-wrapper">
+        <EditorContent :editor="editor" />
+      </div>
+    </transition>
+  </div>
+
+  <hr>
+
+  <!-- Transition with editor in a child component -->
+  <div>
+    <button
+      id="toggle-nested-editor"
+      type="button"
+      style="margin-bottom: 1rem;"
+      @click="showNestedEditor = !showNestedEditor"
+    >
+      {{ showNestedEditor ? 'Hide nested editor' : 'Show nested editor' }}
+    </button>
+
+    <transition name="fade">
+      <div v-if="showNestedEditor" class="tiptap-wrapper">
+        <ParentComponent />
       </div>
     </transition>
   </div>
@@ -62,6 +87,11 @@ const showEditor = ref(false)
   opacity: 0;
 }
 
+hr {
+  margin-top: 1rem;
+  margin-bottom: 1rem;
+}
+
 .tiptap-wrapper {
   background-color: var(--purple-light);
   border: 2px solid var(--purple);
diff --git a/packages/vue-3/src/EditorContent.ts b/packages/vue-3/src/EditorContent.ts
index e4cbaa308f9..46cfad81ea1 100644
--- a/packages/vue-3/src/EditorContent.ts
+++ b/packages/vue-3/src/EditorContent.ts
@@ -59,7 +59,6 @@ export const EditorContent = defineComponent({
 
           editor.createNodeViews()
         })
-
       }
     })
 
diff --git a/packages/vue-3/src/useEditor.ts b/packages/vue-3/src/useEditor.ts
index e75d7f41c1e..9072153278a 100644
--- a/packages/vue-3/src/useEditor.ts
+++ b/packages/vue-3/src/useEditor.ts
@@ -11,6 +11,12 @@ export const useEditor = (options: Partial<EditorOptions> = {}) => {
   })
 
   onBeforeUnmount(() => {
+    // Cloning root node (and its children) to avoid content being lost by destroy
+    const nodes = editor.value?.options.element
+    const newEl = nodes?.cloneNode(true) as HTMLElement
+
+    nodes?.parentNode?.replaceChild(newEl, nodes)
+
     editor.value?.destroy()
   })
 

From 88371561bbb564c9c94a6ebcfdc44fbf0fbeeb25 Mon Sep 17 00:00:00 2001
From: Juraj Garaj <juraj982@gmail.com>
Date: Thu, 7 Nov 2024 09:21:19 +0100
Subject: [PATCH 14/17] fix(list-keymap): early exit when selection is not
 collapsed (#5810)

---
 .changeset/chatty-monkeys-hear.md                           | 5 +++++
 .../src/listHelpers/handleBackspace.ts                      | 6 ++++++
 2 files changed, 11 insertions(+)
 create mode 100644 .changeset/chatty-monkeys-hear.md

diff --git a/.changeset/chatty-monkeys-hear.md b/.changeset/chatty-monkeys-hear.md
new file mode 100644
index 00000000000..8f8d01daf96
--- /dev/null
+++ b/.changeset/chatty-monkeys-hear.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/extension-list-keymap": patch
+---
+
+Fix backspace behavior when selection is not collapsed
diff --git a/packages/extension-list-keymap/src/listHelpers/handleBackspace.ts b/packages/extension-list-keymap/src/listHelpers/handleBackspace.ts
index e1fc012ce30..506347f31c2 100644
--- a/packages/extension-list-keymap/src/listHelpers/handleBackspace.ts
+++ b/packages/extension-list-keymap/src/listHelpers/handleBackspace.ts
@@ -12,6 +12,12 @@ export const handleBackspace = (editor: Editor, name: string, parentListTypes: s
     return true
   }
 
+  // if the selection is not collapsed
+  // we can rely on the default backspace behavior
+  if (editor.state.selection.from !== editor.state.selection.to) {
+    return false
+  }
+
   // if the current item is NOT inside a list item &
   // the previous item is a list (orderedList or bulletList)
   // move the cursor into the list and delete the current item

From 62c6dddf807aa618a727ed9c7320f4a75f4d830d Mon Sep 17 00:00:00 2001
From: Nick Perez <nicholas.perez@tiptap.dev>
Date: Thu, 7 Nov 2024 13:18:01 +0100
Subject: [PATCH 15/17] fix(link): add backwards compat by deprecating validate
 and using isAllowedUri instead (#5812)

---
 demos/src/Marks/Link/React/index.jsx |   2 +-
 packages/extension-link/src/link.ts  | 182 ++++++++++++++++++++-------
 2 files changed, 140 insertions(+), 44 deletions(-)

diff --git a/demos/src/Marks/Link/React/index.jsx b/demos/src/Marks/Link/React/index.jsx
index d9a57661a30..4af6bcff673 100644
--- a/demos/src/Marks/Link/React/index.jsx
+++ b/demos/src/Marks/Link/React/index.jsx
@@ -21,7 +21,7 @@ export default () => {
         autolink: true,
         defaultProtocol: 'https',
         protocols: ['http', 'https'],
-        validate: (url, ctx) => {
+        isAllowedUri: (url, ctx) => {
           try {
             // construct URL
             const parsedUrl = url.includes(':') ? new URL(url) : new URL(`${ctx.defaultProtocol}://${url}`)
diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
index 76368488219..b9b882995b6 100644
--- a/packages/extension-link/src/link.ts
+++ b/packages/extension-link/src/link.ts
@@ -38,52 +38,79 @@ export interface LinkOptions {
    * @default true
    * @example false
    */
-  autolink: boolean
+  autolink: boolean;
 
   /**
    * An array of custom protocols to be registered with linkifyjs.
    * @default []
    * @example ['ftp', 'git']
    */
-  protocols: Array<LinkProtocolOptions | string>
+  protocols: Array<LinkProtocolOptions | string>;
 
   /**
    * Default protocol to use when no protocol is specified.
    * @default 'http'
    */
-  defaultProtocol: string
+  defaultProtocol: string;
   /**
    * If enabled, links will be opened on click.
    * @default true
    * @example false
    */
-  openOnClick: boolean | DeprecatedOpenWhenNotEditable
+  openOnClick: boolean | DeprecatedOpenWhenNotEditable;
   /**
    * Adds a link to the current selection if the pasted content only contains an url.
    * @default true
    * @example false
    */
-  linkOnPaste: boolean
+  linkOnPaste: boolean;
 
   /**
    * HTML attributes to add to the link element.
    * @default {}
    * @example { class: 'foo' }
    */
-  HTMLAttributes: Record<string, any>
+  HTMLAttributes: Record<string, any>;
 
   /**
-   * A validation function that modifies link verification.
+   * @deprecated Use the `shouldAutoLink` option instead.
+   * A validation function that modifies link verification for the auto linker.
+   * @param url - The url to be validated.
+   * @returns - True if the url is valid, false otherwise.
+   */
+  validate: (url: string) => boolean;
+
+  /**
+   * A validation function which is used for configuring link verification for preventing XSS attacks.
+   * Only modify this if you know what you're doing.
    *
-   * @param {string} url - The URL to be validated.
-   * @param {Object} ctx - An object containing:
-   * @param {Function} ctx.defaultValidate - A function that performs the default URL validation.
-   * @param {string[]} ctx.protocols - An array of allowed protocols for the URL (e.g., "http", "https").
-   * @param {string} ctx.defaultProtocol - A string that represents the default protocol (e.g., 'http').
+   * @returns {boolean} `true` if the URL is valid, `false` otherwise.
    *
-   * @returns {boolean} True if the URL is valid, false otherwise.
+   * @example
+   * isAllowedUri: (url, { defaultValidate, protocols, defaultProtocol }) => {
+   * return url.startsWith('./') || defaultValidate(url)
+   * }
    */
-  validate: (url: string, ctx: { defaultValidate: (url: string) => boolean, protocols: Array<LinkProtocolOptions | string>, defaultProtocol: string }) => boolean
+  isAllowedUri: (
+    /**
+     * The URL to be validated.
+     */
+    url: string,
+    ctx: {
+      /**
+       * The default validation function.
+       */
+      defaultValidate: (url: string) => boolean;
+      /**
+       * An array of allowed protocols for the URL (e.g., "http", "https"). As defined in the `protocols` option.
+       */
+      protocols: Array<LinkProtocolOptions | string>;
+      /**
+       * A string that represents the default protocol (e.g., 'http'). As defined in the `defaultProtocol` option.
+       */
+      defaultProtocol: string;
+    }
+  ) => boolean;
 
   /**
    * Determines whether a valid link should be automatically linked in the content.
@@ -91,7 +118,7 @@ export interface LinkOptions {
    * @param {string} url - The URL that has already been validated.
    * @returns {boolean} - True if the link should be auto-linked; false if it should not be auto-linked.
    */
-  shouldAutoLink: (url: string) => boolean
+  shouldAutoLink: (url: string) => boolean;
 }
 
 declare module '@tiptap/core' {
@@ -102,19 +129,29 @@ declare module '@tiptap/core' {
        * @param attributes The link attributes
        * @example editor.commands.setLink({ href: 'https://tiptap.dev' })
        */
-      setLink: (attributes: { href: string; target?: string | null; rel?: string | null; class?: string | null }) => ReturnType
+      setLink: (attributes: {
+        href: string;
+        target?: string | null;
+        rel?: string | null;
+        class?: string | null;
+      }) => ReturnType;
       /**
        * Toggle a link mark
        * @param attributes The link attributes
        * @example editor.commands.toggleLink({ href: 'https://tiptap.dev' })
        */
-      toggleLink: (attributes: { href: string; target?: string | null; rel?: string | null; class?: string | null }) => ReturnType
+      toggleLink: (attributes: {
+        href: string;
+        target?: string | null;
+        rel?: string | null;
+        class?: string | null;
+      }) => ReturnType;
       /**
        * Unset a link mark
        * @example editor.commands.unsetLink()
        */
-      unsetLink: () => ReturnType
-    }
+      unsetLink: () => ReturnType;
+    };
   }
 }
 
@@ -124,11 +161,22 @@ declare module '@tiptap/core' {
 const ATTR_WHITESPACE = /[\u0000-\u0020\u00A0\u1680\u180E\u2000-\u2029\u205F\u3000]/g
 
 function isAllowedUri(uri: string | undefined, protocols?: LinkOptions['protocols']) {
-  const allowedProtocols: string[] = ['http', 'https', 'ftp', 'ftps', 'mailto', 'tel', 'callto', 'sms', 'cid', 'xmpp']
+  const allowedProtocols: string[] = [
+    'http',
+    'https',
+    'ftp',
+    'ftps',
+    'mailto',
+    'tel',
+    'callto',
+    'sms',
+    'cid',
+    'xmpp',
+  ]
 
   if (protocols) {
     protocols.forEach(protocol => {
-      const nextProtocol = (typeof protocol === 'string' ? protocol : protocol.scheme)
+      const nextProtocol = typeof protocol === 'string' ? protocol : protocol.scheme
 
       if (nextProtocol) {
         allowedProtocols.push(nextProtocol)
@@ -136,8 +184,18 @@ function isAllowedUri(uri: string | undefined, protocols?: LinkOptions['protocol
     })
   }
 
-  // eslint-disable-next-line no-useless-escape
-  return !uri || uri.replace(ATTR_WHITESPACE, '').match(new RegExp(`^(?:(?:${allowedProtocols.join('|')}):|[^a-z]|[a-z+.\-]+(?:[^a-z+.\-:]|$))`, 'i'))
+  return (
+    !uri
+    || uri
+      .replace(ATTR_WHITESPACE, '')
+      .match(
+        new RegExp(
+          // eslint-disable-next-line no-useless-escape
+          `^(?:(?:${allowedProtocols.join('|')}):|[^a-z]|[a-z+.\-]+(?:[^a-z+.\-:]|$))`,
+          'i',
+        ),
+      )
+  )
 }
 
 /**
@@ -154,6 +212,13 @@ export const Link = Mark.create<LinkOptions>({
   exitable: true,
 
   onCreate() {
+    if (this.options.validate && !this.options.shouldAutoLink) {
+      // Copy the validate function to the shouldAutoLink option
+      this.options.shouldAutoLink = this.options.validate
+      console.warn(
+        'The `validate` option is deprecated. Rename to the `shouldAutoLink` option instead.',
+      )
+    }
     this.options.protocols.forEach(protocol => {
       if (typeof protocol === 'string') {
         registerCustomProtocol(protocol)
@@ -183,7 +248,8 @@ export const Link = Mark.create<LinkOptions>({
         rel: 'noopener noreferrer nofollow',
         class: null,
       },
-      validate: (url, ctx) => !!isAllowedUri(url, ctx.protocols),
+      isAllowedUri: (url, ctx) => !!isAllowedUri(url, ctx.protocols),
+      validate: url => !!url,
       shouldAutoLink: url => !!url,
     }
   },
@@ -209,25 +275,44 @@ export const Link = Mark.create<LinkOptions>({
   },
 
   parseHTML() {
-    return [{
-      tag: 'a[href]',
-      getAttrs: dom => {
-        const href = (dom as HTMLElement).getAttribute('href')
-
-        // prevent XSS attacks
-        if (!href || !this.options.validate(href, { defaultValidate: url => !!isAllowedUri(url, this.options.protocols), protocols: this.options.protocols, defaultProtocol: this.options.defaultProtocol })) {
-          return false
-        }
-        return null
+    return [
+      {
+        tag: 'a[href]',
+        getAttrs: dom => {
+          const href = (dom as HTMLElement).getAttribute('href')
+
+          // prevent XSS attacks
+          if (
+            !href
+            || !this.options.isAllowedUri(href, {
+              defaultValidate: url => !!isAllowedUri(url, this.options.protocols),
+              protocols: this.options.protocols,
+              defaultProtocol: this.options.defaultProtocol,
+            })
+          ) {
+            return false
+          }
+          return null
+        },
       },
-    }]
+    ]
   },
 
   renderHTML({ HTMLAttributes }) {
     // prevent XSS attacks
-    if (!this.options.validate(HTMLAttributes.href, { defaultValidate: href => !!isAllowedUri(href, this.options.protocols), protocols: this.options.protocols, defaultProtocol: this.options.defaultProtocol })) {
+    if (
+      !this.options.isAllowedUri(HTMLAttributes.href, {
+        defaultValidate: href => !!isAllowedUri(href, this.options.protocols),
+        protocols: this.options.protocols,
+        defaultProtocol: this.options.defaultProtocol,
+      })
+    ) {
       // strip out the href
-      return ['a', mergeAttributes(this.options.HTMLAttributes, { ...HTMLAttributes, href: '' }), 0]
+      return [
+        'a',
+        mergeAttributes(this.options.HTMLAttributes, { ...HTMLAttributes, href: '' }),
+        0,
+      ]
     }
 
     return ['a', mergeAttributes(this.options.HTMLAttributes, HTMLAttributes), 0]
@@ -265,17 +350,24 @@ export const Link = Mark.create<LinkOptions>({
           const foundLinks: PasteRuleMatch[] = []
 
           if (text) {
-            const { validate, protocols, defaultProtocol } = this.options
-            const links = find(text).filter(item => item.isLink && validate(item.value, { defaultValidate: href => !!isAllowedUri(href, protocols), protocols, defaultProtocol }))
+            const { protocols, defaultProtocol } = this.options
+            const links = find(text).filter(
+              item => item.isLink
+                && this.options.isAllowedUri(item.value, {
+                  defaultValidate: href => !!isAllowedUri(href, protocols),
+                  protocols,
+                  defaultProtocol,
+                }),
+            )
 
             if (links.length) {
-              links.forEach(link => (foundLinks.push({
+              links.forEach(link => foundLinks.push({
                 text: link.value,
                 data: {
                   href: link.href,
                 },
                 index: link.start,
-              })))
+              }))
             }
           }
 
@@ -293,14 +385,18 @@ export const Link = Mark.create<LinkOptions>({
 
   addProseMirrorPlugins() {
     const plugins: Plugin[] = []
-    const { validate, protocols, defaultProtocol } = this.options
+    const { protocols, defaultProtocol } = this.options
 
     if (this.options.autolink) {
       plugins.push(
         autolink({
           type: this.type,
           defaultProtocol: this.options.defaultProtocol,
-          validate: url => validate(url, { defaultValidate: href => !!isAllowedUri(href, protocols), protocols, defaultProtocol }),
+          validate: url => this.options.isAllowedUri(url, {
+            defaultValidate: href => !!isAllowedUri(href, protocols),
+            protocols,
+            defaultProtocol,
+          }),
           shouldAutoLink: this.options.shouldAutoLink,
         }),
       )

From 53673fbfe0c2f41ed2d2caae0b554ecbf3d03803 Mon Sep 17 00:00:00 2001
From: Nick Perez <nicholas.perez@tiptap.dev>
Date: Fri, 8 Nov 2024 10:49:50 +0100
Subject: [PATCH 16/17] feat: add `once` to EventEmitters (#5818)

---
 .changeset/lemon-berries-change.md | 5 +++++
 packages/core/src/EventEmitter.ts  | 9 +++++++++
 2 files changed, 14 insertions(+)
 create mode 100644 .changeset/lemon-berries-change.md

diff --git a/.changeset/lemon-berries-change.md b/.changeset/lemon-berries-change.md
new file mode 100644
index 00000000000..2748fe225aa
--- /dev/null
+++ b/.changeset/lemon-berries-change.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/core": patch
+---
+
+feat: add `once` to EventEmitters
diff --git a/packages/core/src/EventEmitter.ts b/packages/core/src/EventEmitter.ts
index 0aa0fe88005..104ecf63359 100644
--- a/packages/core/src/EventEmitter.ts
+++ b/packages/core/src/EventEmitter.ts
@@ -46,6 +46,15 @@ export class EventEmitter<T extends Record<string, any>> {
     return this
   }
 
+  public once<EventName extends StringKeyOf<T>>(event: EventName, fn: CallbackFunction<T, EventName>): this {
+    const onceFn = (...args: CallbackType<T, EventName>) => {
+      this.off(event, onceFn)
+      fn.apply(this, args)
+    }
+
+    return this.on(event, onceFn)
+  }
+
   public removeAllListeners(): void {
     this.callbacks = {}
   }

From 21781189916647ce92eeafecc6e4a2cd56d21ece Mon Sep 17 00:00:00 2001
From: Glenn Allen <glenn.allen@milanote.com>
Date: Mon, 11 Nov 2024 19:05:32 +1100
Subject: [PATCH 17/17] feat: add Node `linebreakReplacement` support and
 enable on hardBreak nodes (#5821)

* Support the Node linebreakReplacement property

Support the [linebreakReplacement](https://prosemirror.net/docs/ref/#model.NodeSpec.linebreakReplacement) property on Nodes, allowing a node to be used wherever a newline character is, when converting between blocks that don't support the linebreak node, but have their whitespace set to "pre".

This is useful, for example, when converting between code blocks & normal paragraphs. Code blocks don't support the linebreak node, but do allow newline characters ('\n').
Marking the `hardBreak` node as the `linebreakReplacement` will mean the newline characters within codeBlock nodes will be converted to `hardBreak` nodes in the paragraph.

* Make hardBreak the default linebreakReplacement node

When converting between codeBlocks and normal paragraphs, the hardBreak node should be used in place of newline '\n' characters.
---
 .changeset/shy-pigs-exercise.md               |  6 ++++++
 packages/core/src/Node.ts                     | 19 +++++++++++++++++++
 .../helpers/getSchemaByResolvedExtensions.ts  |  1 +
 .../extension-hard-break/src/hard-break.ts    |  2 ++
 4 files changed, 28 insertions(+)
 create mode 100644 .changeset/shy-pigs-exercise.md

diff --git a/.changeset/shy-pigs-exercise.md b/.changeset/shy-pigs-exercise.md
new file mode 100644
index 00000000000..16e4d26ffc7
--- /dev/null
+++ b/.changeset/shy-pigs-exercise.md
@@ -0,0 +1,6 @@
+---
+"@tiptap/core": patch
+"@tiptap/extension-hard-break": patch
+---
+
+Add Node `linebreakReplacement` support and enable on hard-break nodes
diff --git a/packages/core/src/Node.ts b/packages/core/src/Node.ts
index 19d01ca81ca..567e0eef7d6 100644
--- a/packages/core/src/Node.ts
+++ b/packages/core/src/Node.ts
@@ -595,6 +595,25 @@ declare module '@tiptap/core' {
           editor?: Editor
         }) => NodeSpec['whitespace'])
 
+    /**
+     * Allows a **single** node to be set as linebreak equivalent (e.g. hardBreak).
+     * When converting between block types that have whitespace set to "pre"
+     * and don't support the linebreak node (e.g. codeBlock) and other block types
+     * that do support the linebreak node (e.g. paragraphs) - this node will be used
+     * as the linebreak instead of stripping the newline.
+     *
+     * See [linebreakReplacement](https://prosemirror.net/docs/ref/#model.NodeSpec.linebreakReplacement).
+     */
+    linebreakReplacement?:
+      | NodeSpec['linebreakReplacement']
+      | ((this: {
+          name: string
+          options: Options
+          storage: Storage
+          parent: ParentConfig<NodeConfig<Options, Storage>>['linebreakReplacement']
+          editor?: Editor
+        }) => NodeSpec['linebreakReplacement'])
+
     /**
      * When enabled, enables both
      * [`definingAsContext`](https://prosemirror.net/docs/ref/#model.NodeSpec.definingAsContext) and
diff --git a/packages/core/src/helpers/getSchemaByResolvedExtensions.ts b/packages/core/src/helpers/getSchemaByResolvedExtensions.ts
index 25b856140f3..6022981720f 100644
--- a/packages/core/src/helpers/getSchemaByResolvedExtensions.ts
+++ b/packages/core/src/helpers/getSchemaByResolvedExtensions.ts
@@ -78,6 +78,7 @@ export function getSchemaByResolvedExtensions(extensions: Extensions, editor?: E
         ),
         code: callOrReturn(getExtensionField<NodeConfig['code']>(extension, 'code', context)),
         whitespace: callOrReturn(getExtensionField<NodeConfig['whitespace']>(extension, 'whitespace', context)),
+        linebreakReplacement: callOrReturn(getExtensionField<NodeConfig['linebreakReplacement']>(extension, 'linebreakReplacement', context)),
         defining: callOrReturn(
           getExtensionField<NodeConfig['defining']>(extension, 'defining', context),
         ),
diff --git a/packages/extension-hard-break/src/hard-break.ts b/packages/extension-hard-break/src/hard-break.ts
index 6461faf5b5e..ed5b9a68b56 100644
--- a/packages/extension-hard-break/src/hard-break.ts
+++ b/packages/extension-hard-break/src/hard-break.ts
@@ -48,6 +48,8 @@ export const HardBreak = Node.create<HardBreakOptions>({
 
   selectable: false,
 
+  linebreakReplacement: true,
+
   parseHTML() {
     return [
       { tag: 'br' },