Check the tree like invariant #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that environment reduction is disabled in LH, tests pass there with this extra check. |
facundominguez
force-pushed
the
fd/tree-like-invariant
branch
from
afdb2bd to
77421e2
Compare
facundominguez
force-pushed
the
fd/tree-like-invariant
branch
from
77421e2 to
1902323
Compare
|
This is good to merge, unless anyone has requests. I seized the opportunity to update CI to use VMs, in the same way we do in the LiquidHaskell CI. VMs get more memory than docker containers and the first attempt in this PR had failed with an OOM error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives feedback to the user when the tree-like invariant doesn't hold.
This is a temporary remedy until we fix #496.