Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Residual use in Tree #21

Open
HGuillemet opened this issue Apr 6, 2021 · 0 comments
Open

Residual use in Tree #21

HGuillemet opened this issue Apr 6, 2021 · 0 comments

Comments

@HGuillemet
Copy link

HGuillemet commented Apr 6, 2021 •
edited
Loading

In the forward method of the Tree class in dla.py, the residual argument is always ignored (overriden line 209).
Is it what is wanted ?
If it is, then building project in the constructor and calling its forward method it line 209 is useless when levels > 1. Some computation could be saved.
Also bottom computation is not used if levels > 1 and level_root is false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HGuillemet