Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Stage .pol files as XML and convert to .pol on the fly #794

Open
2 tasks done
GabrielNagy opened this issue Sep 25, 2023 · 0 comments
Open
2 tasks done

Feature: Stage .pol files as XML and convert to .pol on the fly #794

GabrielNagy opened this issue Sep 25, 2023 · 0 comments
Labels
enhancement New feature or request jira Import to Jira

Comments

@GabrielNagy
Copy link
Contributor

Is there an existing request for this feature?

  • I have searched the existing issues and found none that matched mine

Describe the feature

We have a number of .pol files checked in that we use for tests which are currently edited by hand when needed. This can easily become overwhelming as the file is partly encoded in UTF-16 except for the first few bytes and we need to use a hex editor to do so.

Moreover, git cannot provide a clear view of the changes due to the same reason, making reviews almost impossible. As the file is not plain text, we cannot to a roundtrip conversion from UTF-16 to UTF-8 without losing data in the process.

Describe the ideal solution

Ideally these files are staged in a human readable format (e.g. XML), and compiled to .pol files on the fly, before tests are run. This would simplify content manipulation, and make code review much easier.

This functionality can be achieved by using the GPPolParser class provided by samba, which we can use to convert all our .pol files to XML files, then convert back when tests are being run. Thus, .pol files will no longer be committed to version control.

Alternatives and current workarounds

n/a

Ubuntu users: System information

n/a

Non Ubuntu users: System information

n/a

Additional information

No response

Double check your logs

  • I have redacted any sensitive information from the logs
@GabrielNagy GabrielNagy added enhancement New feature or request jira Import to Jira labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira Import to Jira
Projects
None yet
Development

No branches or pull requests

1 participant