Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Allow greeter rotation #419

Closed
capsia37 opened this issue Dec 7, 2021 · 4 comments · Fixed by #418 or #402
Closed

Allow greeter rotation #419

capsia37 opened this issue Dec 7, 2021 · 4 comments · Fixed by #418 or #402

Comments

@capsia37
Copy link
Contributor

capsia37 commented Dec 7, 2021

Allow the greeter to rotate and make it responsive so it will look good at any screen size.

@j2g2rp
Copy link
Contributor

j2g2rp commented Jan 16, 2022

Rotation is working fine on M10FHD and on Volla x.
I would say that there is just one problem of consistency on M10FHD when it is horizontal:
Here is the greeting screen on M10 when horizontal before swiping:
screenshot20220116_181732784
after swiping:
screenshot20220116_181743321
and this is when vertical before swiping:
screenshot20220116_181756631
after swiping:
screenshot20220116_181810912

On vollaphone seems consistent on horizontal:
screenshot20220116_183827588
screenshot20220116_183833474

PS. I waited this feature for years, thank you! 😁😁😁

@capsia37
Copy link
Contributor Author

Rotation is working fine on M10FHD and on Volla x. I would say that there is just one problem of consistency on M10FHD when it is horizontal: Here is the greeting screen on M10 when horizontal before swiping.

Hello @j2g2rp and thank you for the feedback. I've originally wanted to move the infographics in tablet and desktop mode near the login prompt to allow showing and updating them while switching users in a multi-user setup. In the portrait mode the infographics wouldn't fit, but in landscape I've put it there. Since we are currently limited to only one user anyway, it would be more consistent to keep it always on the cover page :)

@cibersheep
Copy link
Contributor

cibersheep commented Jan 18, 2022

There is an small issue ^_^
#422

@c4pp4
Copy link

c4pp4 commented Jan 28, 2022

RC OTA22: 2022-W04 (devices: Mi A2 (display (1080 x 2160) and Xperia X (display 1080x1920))
Works. There is no issue like 422. But one thing I noticed. When in landscape orientation, keyboard on Xperia X fills 1/2 of display height and it's very comfortable to write on it. On the other hand the keyboard on Mi A2 fills cca 1/4 of display height and is very tiny, just like @j2g2rp Volla phone screenshot.

capsia37 added a commit to capsia37/unity8 that referenced this issue Jan 29, 2022
- Don't show infographics if space is not enough

- Show infographics on cover for single user tablets

See:

ubports#419 (comment)

ubports#422
capsia37 added a commit to capsia37/unity8 that referenced this issue Jan 31, 2022
- Don't show infographics if space is not enough

- Show infographics on cover for single user tablets

See:

ubports#419 (comment)

ubports#422
capsia37 added a commit to capsia37/unity8 that referenced this issue Jan 31, 2022
- Don't show infographics if space is not enough

- Show infographics on cover for single user tablets

See:

ubports#419 (comment)

ubports#422
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants