Skip to content
This repository has been archived by the owner on Nov 18, 2018. It is now read-only.

Latest commit

 

History

History
17 lines (11 loc) · 689 Bytes

README-PullRequest.md

File metadata and controls

17 lines (11 loc) · 689 Bytes

Prerequisites to approving a Pull Request (PR)

Over time, it has been found that insufficient testing by reviewers sometimes leads to music app not buildable due to manifest errors, or translation pot file not updated. As such, please follow the checklist below before top-approving a PR.

Checklist

  • Does the PR change the UI? If Yes, has it been approved by design?

  • Did you perform an exploratory manual test run of your code change and any related functionality?

  • Was the copyright years updated if necessary?

The above checklist is more of a guideline to help music app stay buildable, stable and up to date.