Skip to content
This repository has been archived by the owner on Mar 8, 2019. It is now read-only.

Whole-day-events are shown at the wrong day in calendar indicator #88

Open
Flohack74 opened this issue May 24, 2018 · 9 comments
Open

Comments

@Flohack74
Copy link
Member

From @jonnius on May 24, 2018 10:9

  • Device: FP2
  • Channel: 16.04/devel
  • Build: r301

Steps to reproduce

Create a event for a whole day. Open the calendar indicator (swipe from the top). Tap at the day you created the event for.

Expected behavior

The event is displayed in the list beneath the calendar.

Actual behavior

The event is not displayed in the list beneath the calendar. But if you tap one of the days before, it gets displayed in the event list. Another detail: 0.00 is shown as the time of the event. Imho it would be better not to show any time at all or maybe something indicating it is a whole-day-event.

Logfiles and additional information

The dot indicating the event is shown at the right day.

Copied from original issue: ubports/ubuntu-touch#628

@hummlbach
Copy link
Collaborator

hummlbach commented May 24, 2018

But this is about the date-time-indicator...?!? Sure you don't want to move it here: https://github.com/ubports/indicator-datetime? ah issues disabled there... so mhmm...

@hummlbach
Copy link
Collaborator

hummlbach commented May 24, 2018

This seems to be intended... it displays the upcoming events only... (from the day after the day you tapped on)
ubports/indicator-datetime@696d022

@hummlbach
Copy link
Collaborator

But I don't like having this issue here... @Flohack74 please put it back to where you picked it up from... ^^

@jonnius
Copy link
Contributor

jonnius commented May 24, 2018

I dont get that intention. I have a calendar and see dots on some days that represent events. If I want to know what that is, I tap on that day. But nothing is shown there. So I always need to tap the day before that day to see its events. That idea is weird.

Btw, this works fine if the event has defined hours.

@jonnius
Copy link
Contributor

jonnius commented May 24, 2018

Looking at the code I think the problem is that midnight is the exclusive limit, but should be the inclusive limit. Whole-day-events start at midnight and should be included in that day.

@hummlbach
Copy link
Collaborator

Oh yes, you're right!

@hummlbach
Copy link
Collaborator

I can confirm this and have to add: If its a multiple full day event, there is only one dot displayed on the first day. Don't know if thats intended...

@ruedigerkupper
Copy link

Confirmed.

@dobey
Copy link
Member

dobey commented Nov 5, 2018

FWIW, this was also reported on Launchpad already, with some more useful info, at https://bugs.launchpad.net/ubuntu/+source/indicator-datetime/+bug/1261191

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants