Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Update following-up for the assigneer #863

Open
wannacfuture opened this issue Oct 17, 2023 · 0 comments
Open

Update following-up for the assigneer #863

wannacfuture opened this issue Oct 17, 2023 · 0 comments

Comments

@wannacfuture
Copy link
Contributor

wannacfuture commented Oct 17, 2023

Currently we check the last commit date and comment of the assigneer on the linked PR to include them to last activity time of the assigneer.

While investigating the codebase, I just realized that wrong function is being used to get the linked PR.
https://github.com/ubiquity/ubiquibot/blob/3ad77e54a0202e442bdc7e2973326e8a7a32b74a/src/handlers/wildcard/unassign.ts#L113C35-L113C66

Also, it checks any linked PR without checking if the PR's author is assigneer.

  • We need to replace getOpenedPullRequestsForAnIssue function with gitLinkedPrParser.
  • Also, we need to check the last commit date and comment only for the assigneer's PR.
@wannacfuture wannacfuture changed the title Update follow-up for the assigneer for an issue Update following-up for the assigneer Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant