Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Add bounty rewards consolidation #704

Closed
rndquu opened this issue Sep 1, 2023 · 7 comments · Fixed by #714
Closed

Add bounty rewards consolidation #704

rndquu opened this issue Sep 1, 2023 · 7 comments · Fixed by #714

Comments

@rndquu
Copy link
Member

rndquu commented Sep 1, 2023

Check this issue

When issue is solved then the following participants get rewards:

  • issue creator
  • issue solver
  • issue commenter

When the same person creates an issue and comments in an issue then we need to generate 2 permits for that user (issue creator + issue commenter). We should consolidate such permits in a single one. So when an issue is closed then all permits should be grouped by users.

Thera are 2 exceptions:

  1. Issue solver shouldn't get issue commenter rewards
  2. Issue creator shouldn't get issue commenter rewards

What should be done:

  • combine all generated permits by user
  • remove type from permit generation method (it was initially implemented here as a kind of a hotfix) and use keccak256(issue.node_id . bountyHunter.node_id) for permit nonces
  • combined permits should have a caption that states the reason behind the generated permit, ex: "Issue creator and issue solver rewards"
@devpanther
Copy link
Contributor

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 1, 2023

Deadline Sat, 02 Sep 2023 18:57:12 UTC
Registered Wallet 0xf76F1ACB66020f893c95371f740549F312DEA3f1
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @rndquu
    Copy link
    Member Author

    rndquu commented Sep 4, 2023

    @devpanther Sorry for the inconvenience. The spec has been updated with those 2 edge cases:

    Thera are 2 exceptions:
    1. Issue solver shouldn't get issue commenter rewards
    2. Issue creator shouldn't get issue commenter rewards
    

    @Draeieg
    Copy link
    Contributor

    Draeieg commented Sep 17, 2023

    @devpanther Sorry for the inconvenience. The spec has been updated with those 2 edge cases:

    Thera are 2 exceptions:
    1. Issue solver shouldn't get issue commenter rewards
    2. Issue creator shouldn't get issue commenter rewards
    

    @devpanther Sorry for ANOTHER inconvenience lol

    issue solver and creator getting commenter rewards should be a setting we can turn on or off for a given repository, this is to make Non code bounties/tasks like research possible

    idk if this should be within the scope of this bounty of another one @pavlovcik

    @0x4007
    Copy link
    Member

    0x4007 commented Sep 17, 2023

    No more scope changes here.

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 21, 2023

    Task Assignee Reward

    [ CLAIM 150 WXDAI ]

    0xf76F1ACB...312DEA3f1

    If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
    We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 21, 2023

    Task Creator Reward

    rndquu: [ CLAIM 89.2 WXDAI ]

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    4 participants