-
Notifications
You must be signed in to change notification settings - Fork 61
Read DEFAULT_TIME_RANGE_FOR_MAX_ISSUE
from env
#619
Comments
/start |
Tips:
|
Task Assignee Reward[ CLAIM 75 WXDAI ]
If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you! |
Task Creator Rewardrndquu: [ CLAIM 89 WXDAI ] |
I just dug this up from the logs (id: 650) Why did this Task Creator Reward add up to be 89 WXDAI? This is quite a bit higher than expected Loaded config: {
"price": {
"baseMultiplier": 1.5,
"issueCreatorMultiplier": 2,
"timeLabels": [
{
"name": "Time: <1 Hour",
"weight": 0.125,
"value": 3600
},
{
"name": "Time: <2 Hours",
"weight": 0.25,
"value": 7200
},
{
"name": "Time: <4 Hours",
"weight": 0.5,
"value": 14400
},
{
"name": "Time: <1 Day",
"weight": 1,
"value": 86400
},
{
"name": "Time: <1 Week",
"weight": 2,
"value": 604800
}
],
"priorityLabels": [
{
"name": "Priority: 0 (Normal)",
"weight": 1
},
{
"name": "Priority: 1 (Medium)",
"weight": 2
},
{
"name": "Priority: 2 (High)",
"weight": 3
},
{
"name": "Priority: 3 (Urgent)",
"weight": 4
},
{
"name": "Priority: 4 (Emergency)",
"weight": 5
}
],
"incentives": {
"comment": {
"elements": {
"code": 5,
"img": 5,
"h1": 1,
"li": 0.5,
"a": 0.5,
"blockquote": 0
},
"totals": {
"word": 0.1
}
}
},
"defaultLabels": [
"Time: <1 Hour",
"Priority: 0 (Normal)"
]
},
"unassign": {
"followUpTime": 345600000,
"disqualifyTime": 604800000
},
"mode": {
"paymentPermitMaxPrice": 1000,
"disableAnalytics": true,
"incentiveMode": true,
"assistivePricing": true
},
"log": {
"logEnvironment": "production",
"level": "info",
"retryLimit": 0
},
"wallet": {
"registerWalletWithVerification": false
}
} |
I also see a suspicious log related to parsing the original specification. Perhaps it is giving credit to the HTML code that GitHub automatically generates? I think we might need to scrub out all html attributes? <p dir="auto">Original <a href="https://github.com/ubiquibot/ubiquibot-config/pull/2#discussion_r1293969395" data-hovercard-type="pull_request" data-hovercard-url="/ubiquibot/ubiquibot-config/pull/2/hovercard">discussion</a></p>
<p dir="auto">For QA purposes we need to read <a href="https://github.com/ubiquity/ubiquibot/blob/d56a523c81829e17513f7da1f1ccb1bbdca8b180/src/configs/shared.ts#L6">DEFAULT_TIME_RANGE_FOR_MAX_ISSUE</a> and <a href="https://github.com/ubiquity/ubiquibot/blob/d56a523c81829e17513f7da1f1ccb1bbdca8b180/src/configs/shared.ts#L7C14-L7C54">DEFAULT_TIME_RANGE_FOR_MAX_ISSUE_ENABLED</a> from env variables so that <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Draeieg/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Draeieg">@Draeieg</a> could set them in the netlify dashboard for testing purposes</p>
<p dir="auto">What should be done:</p>
<ol dir="auto">
<li>Read <code class="notranslate">DEFAULT_TIME_RANGE_FOR_MAX_ISSUE</code> and <code class="notranslate">DEFAULT_TIME_RANGE_FOR_MAX_ISSUE_ENABLED</code> from <code class="notranslate">process.env</code></li>
<li>By default set <code class="notranslate">DEFAULT_TIME_RANGE_FOR_MAX_ISSUE</code> to <code class="notranslate">24</code> (if env variable is empty)</li>
<li>By default set <code class="notranslate">DEFAULT_TIME_RANGE_FOR_MAX_ISSUE_ENABLED</code> to <code class="notranslate">true</code> (if env variable is empty)</li>
</ol> |
Hmm I guess we can skip links that point to github.com? |
I think its okay, but we must scrub the links in the attributes. Only count
Where the second one should be like $5 a pop. The first one should be like $1 I believe that the first one is |
It only counts tags, attributes don't matter.
We don't use mdast anymore though. I can make it to stop recursing the HTML DOM when it hits |
|
Original discussion
For QA purposes we need to read DEFAULT_TIME_RANGE_FOR_MAX_ISSUE and DEFAULT_TIME_RANGE_FOR_MAX_ISSUE_ENABLED from env variables so that @Draeieg could set them in the netlify dashboard for testing purposes
What should be done:
DEFAULT_TIME_RANGE_FOR_MAX_ISSUE
andDEFAULT_TIME_RANGE_FOR_MAX_ISSUE_ENABLED
fromprocess.env
DEFAULT_TIME_RANGE_FOR_MAX_ISSUE
to24
(if env variable is empty)DEFAULT_TIME_RANGE_FOR_MAX_ISSUE_ENABLED
totrue
(if env variable is empty)The text was updated successfully, but these errors were encountered: