Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use link instead of massive footer #365

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

3scava1i3r
Copy link

Resolves #344

image

@ubiquity-os-deployer
Copy link

Copy link
Contributor

Preview Deployment
133cb38a63e5935757b8667c2774c6f55043f935

@EresDev
Copy link
Contributor

EresDev commented Dec 23, 2024

The card related info in the footer is dynamic. This PR doesn't seem to address that. But it was improved in #362 by printing a summary with a ...READ MORE toggle. Let's see what issue author thinks about this.

image

@3scava1i3r
Copy link
Author

@EresDev do you mean this?image

The section where it says no card found?

@0x4007
Copy link
Member

0x4007 commented Dec 23, 2024

The section where it says no card found?

What country are you in? This is geography dependent

@3scava1i3r
Copy link
Author

Currently India

@EresDev
Copy link
Contributor

EresDev commented Dec 23, 2024

The section where it says no card found?

What country are you in? This is geography dependent

0$ permit will never offer you a payment card. Most cards are available between 5 to 1000$.

You can use any permit link. This will be read-only for you but enough for you to debug UI i think. You can replace pay.ubq.fi wtth your localhost setup and it should still work with same config. Here is mine. Cards are available for specific countries. Read this. Try with South Korea, USA, Germany, Canada.

In case above permit link doesn't work for you. You need a permit with suffient amount to see card and its redeem info.

@EresDev
Copy link
Contributor

EresDev commented Dec 23, 2024

@EresDev do you mean this?
The section where it says no card found?

No. The section where it says How to use redeem code? in my shared image.

@0x4007
Copy link
Member

0x4007 commented Dec 23, 2024

"Or mint a payment card" is too large make the font size all the sam and clean up the footer.

@EresDev the "see more" is fine but this link i think is much better instead of rendering everything in the footer.

I guess in the test link we should now change it to a $5 permit etc.

@EresDev
Copy link
Contributor

EresDev commented Dec 30, 2024

I guess in the test link we should now change it to a $5 permit etc.

I have added it to a list of improvements. #366 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer
3 participants