Preview Deployer Bug #298
Comments
|
@0x4007 Would you explain more about this issue? what should be the desired outcome? Is there any way to reproduce this? |
|
@gitcoindev this might be your department since you implemented the KNIP CI and not sure if you implemented the deployer with a sample permit. |
There's the knip-reporter.yml workflow which posts in github PR comments a list of unused dependencies if there are any (knip comment example). There's also this workflow step which posts a preview deployment URL with a ready to use URL-encoded permit for ease of QAing (example). The issue is that somehow both the knip reporter and "post preview URL" step posts in a single comment (as shown in the issue description) while the expected behavior is that knip report and preview URL should be posted in separate comments. |
|
/start |
Tip
|
|
@gentlementlegen Help, trying to debug why permits are not created. In cloudflare logs there's this error: But https://github.com/apps/ubiquity-os seems to be properly installed in https://github.com/ubiquity. |
|
@rndquu I do not have any access to this org in terms of settings so I am not sure. If the error is that the installation is suspended it should mean that the installed apps on this repo are either disabled, or the ones they are calling are disabled on the target (sorry cannot see these since I have no access here). @0x4007 which apps are installed and running here? Should be either |
|
ubiquity-os not dev 
it is installed in marketplace as well so it should be able to access those plugins without a problem 
|
|
@0x4007 On your screenshot it is disabled due to permission requests it seems. |
|
It doesn't indicate suspension. Besides that doesn't make sense that GitHub would disable the entire app just because a new permission was requested and a partner didn't get around to approving right away. It still has a ton of other permissions it can operate perfectly fine with. |
|
Right I thought the orange dot meant that but it seems it just indicates that it is pending evaluation. If the error that @rndquu points out is correct, something should be disabled, but marketplace seems to have both. I'll open and close again to check logs. |
|
@0x4007 Found the error: it is calling |
Thank you, I'll try to update the config. There's a separate config for https://github.com/ubiquity/pay.ubq.fi since we were trying how UUSD payouts work out. So we renamed https://github.com/ubiquibot/conversation-rewards to https://github.com/ubiquity-os-marketplace/text-conversation-rewards/ and the kernel now throws an error when calling the old https://github.com/ubiquibot/conversation-rewards although it redirects to https://github.com/ubiquity-os-marketplace/text-conversation-rewards. Is there a way to force the kernel to follow redirects on renaming plugin repositories? |
|
@rndquu It seems that Octokit doesn't resolve redirects, I might be wrong but so far every time the old path to the repo (e.g. |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 75 |
| Review | Comment | 7 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Resolves #298 | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0
result: 0
| 0.2 | 0 |
As you can see here this works. But I don't know what bot I shou… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 32
wordValue: 0
result: 0
| 0.3 | 0 |
It isn't apparently :pWill run QA | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 8
wordValue: 0
result: 0
| 0.1 | 0 |
@0x4007 QA here: https://github.com/zugdev/pay.ubq.fi/pull/1 you… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 22
wordValue: 0
result: 0
| 0.4 | 0 |
The reason is `knip-reporter.yml` runs faster than `… | 2content:
content:
p:
score: 0
elementCount: 5
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 2
result: 2
regex:
wordCount: 115
wordValue: 0
result: 0
| 0.9 | 0 |
Am I the one to solve conflict? | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0
result: 0
| 0.1 | 0 |
That's a good question. I chose this approach because we guarant… | 5content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 153
wordValue: 0
result: 0
| 0.8 | 0 |
[ 0.2635 UUSD ]
@hhio618
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 1 | 0.2635 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
@0x4007 Would you explain more about this issue? what should be … | 1.33content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 21
wordValue: 0.1
result: 1.33
| 0.8 | 0.2635 |
[ 73.943 UUSD ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 61.5 |
| Issue | Comment | 3 | 11.205 |
| Review | Comment | 2 | 1.238 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Crazy bug that edited and embedded the preview deploy inside of … | 20.5content:
content:
p:
score: 0
elementCount: 8
a:
score: 5
elementCount: 3
h3:
score: 1
elementCount: 1
em:
score: 0
elementCount: 1
result: 16
regex:
wordCount: 88
wordValue: 0.1
result: 4.5
| 1 | 61.5 |
@gitcoindev this might be your department since you implemented … | 1.49content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 24
wordValue: 0.1
result: 1.49
| 0.7 | 1.043 |
ubiquity-os not dev<img width="1433" alt="image" src="https… | 3.11content:
content:
p:
score: 0
elementCount: 4
hr:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 57
wordValue: 0.1
result: 3.11
| 0.9 | 2.799 |
![image](https://github.com/user-attachments/assets/1172ef7f-3de… | 7.78content:
content:
p:
score: 0
elementCount: 1
img:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 50
wordValue: 0.1
result: 2.78
| 0.85 | 7.363 |
Maybe eventually we can auth with a custom app | 0.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0.1
result: 0.65
| 0.6 | 0.39 |
github-actions bot is fine to auth with. Is it using your code w… | 1.06content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 16
wordValue: 0.1
result: 1.06
| 0.8 | 0.848 |
[ 100.027 UUSD ]
@rndquu
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 3 | 34.883 |
| Review | Comment | 3 | 65.144 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
There's the [knip-reporter.yml](https://github.com/ubiquity/pay.… | 29.67content:
content:
p:
score: 0
elementCount: 3
a:
score: 5
elementCount: 5
result: 25
regex:
wordCount: 92
wordValue: 0.1
result: 4.67
| 0.9 | 29.203 |
@gentlementlegen Help, trying to debug why permits are not creat… | 2content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 34
wordValue: 0.1
result: 2
| 0.8 | 1.6 |
Thank you, I'll try to update the config. There's a separate con… | 4.8content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 95
wordValue: 0.1
result: 4.8
| 0.85 | 4.08 |
@zugdev 1. What is the root cause of the issue? [Here](https:/… | 34.92content:
content:
p:
score: 0
elementCount: 3
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 2
a:
score: 5
elementCount: 6
result: 32
regex:
wordCount: 53
wordValue: 0.1
result: 2.92
| 0.7 | 34.044 |
More questions:1. Why do we even need to modify [knip-reporter… | 31.8content:
content:
p:
score: 0
elementCount: 4
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 2
a:
score: 5
elementCount: 5
result: 27
regex:
wordCount: 95
wordValue: 0.1
result: 4.8
| 0.8 | 30.84 |
Yes, PR authors are supposed to resolve code conflicts | 0.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0.1
result: 0.65
| 0.4 | 0.26 |
[ 8.948 UUSD ]
@gentlementlegen
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 5 | 8.948 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
@rndquu I do not have any access to this org in terms of setting… | 3.88content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 74
wordValue: 0.1
result: 3.88
| 0.8 | 3.104 |
@0x4007 On your screenshot it is disabled due to permission requ… | 0.88content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 13
wordValue: 0.1
result: 0.88
| 0.7 | 0.616 |
Right I thought the orange dot meant that but it seems it just i… | 2.64content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 47
wordValue: 0.1
result: 2.64
| 0.6 | 1.584 |
@0x4007 Found the error: it is calling `ubiquibot` repos… | 1.7content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 28
wordValue: 0.1
result: 1.7
| 0.9 | 1.53 |
@rndquu It seems that Octokit doesn't resolve redirects, I might… | 3.02content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 55
wordValue: 0.1
result: 3.02
| 0.7 | 2.114 |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 75 |
| Review | Comment | 7 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Resolves #298 | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0
result: 0
| 0.3 | 0 |
As you can see here this works. But I don't know what bot I shou… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 32
wordValue: 0
result: 0
| 0.7 | 0 |
It isn't apparently :pWill run QA | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 8
wordValue: 0
result: 0
| 0.2 | 0 |
@0x4007 QA here: https://github.com/zugdev/pay.ubq.fi/pull/1 you… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 22
wordValue: 0
result: 0
| 0.5 | 0 |
The reason is `knip-reporter.yml` runs faster than `… | 2content:
content:
p:
score: 0
elementCount: 5
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 2
result: 2
regex:
wordCount: 115
wordValue: 0
result: 0
| 0.9 | 0 |
Am I the one to solve conflict? | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0
result: 0
| 0.1 | 0 |
That's a good question. I chose this approach because we guarant… | 5content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 153
wordValue: 0
result: 0
| 0.8 | 0 |
[ 0.246875 UUSD ]
@hhio618
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 1 | 0.246875 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
@0x4007 Would you explain more about this issue? what should be … | 1.33content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 21
wordValue: 0.1
result: 1.33
| 0.75 | 0.246875 |
[ 73.131 UUSD ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 61.5 |
| Issue | Comment | 3 | 10.328 |
| Review | Comment | 2 | 1.303 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Crazy bug that edited and embedded the preview deploy inside of … | 20.5content:
content:
p:
score: 0
elementCount: 8
a:
score: 5
elementCount: 3
h3:
score: 1
elementCount: 1
em:
score: 0
elementCount: 1
result: 16
regex:
wordCount: 88
wordValue: 0.1
result: 4.5
| 1 | 61.5 |
@gitcoindev this might be your department since you implemented … | 1.49content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 24
wordValue: 0.1
result: 1.49
| 0.6 | 0.894 |
ubiquity-os not dev<img width="1433" alt="image" src="https… | 3.11content:
content:
p:
score: 0
elementCount: 4
hr:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 57
wordValue: 0.1
result: 3.11
| 0.8 | 2.488 |
Crazy bug that edited and embedded the preview deploy inside of Knip. We're going to need to make sure it posts to a separate comment in this situation.
Make sure to also auth the bot as our branded, UbiquityOS bot. Or at least the continuous deploys bot. Or ideally perhaps a dedicated one.
Check here.
Unused exports (1)
reverseEnsInterfaceOriginally posted by @github-actions[bot] in #297 (comment)
The text was updated successfully, but these errors were encountered: