Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce loading time #168

Closed
Keyrxng opened this issue Feb 20, 2024 · 10 comments · Fixed by #169
Closed

Reduce loading time #168

Keyrxng opened this issue Feb 20, 2024 · 10 comments · Fixed by #169
Assignees
@Keyrxng
Labels
Price: 200 USD Priority: 2 (Medium) Time: <4 Hours

Comments

@Keyrxng
Copy link
Contributor

Keyrxng commented Feb 20, 2024

Follow-on task to #158

The goal is to reduce TTC (time till claimable) by increasing performance or removing roadblocks

  • Optimistically render the static data available so as to remove the loading components all together
  • Circumvent slow RPC calls either via RPC reselection or something other
  • In the case of slow calls display what can be displayed do not wait until completion or reselection

Original discussion:
@0x4007
Copy link
Member

0x4007 commented Feb 20, 2024

Not sure if this is a two or four hour task

@Keyrxng Keyrxng mentioned this issue Feb 20, 2024
Merged
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 20, 2024

The bot hasn't linked me yet, I'm not going to assign myself and see if it auto-assigns

Whatever you think is fair I'm good with whatever either way

@0x4007
Copy link
Member

0x4007 commented Feb 20, 2024 •
edited
Loading

The bot hasn't linked me yet, I'm not going to assign myself and see if it auto-assigns

Whatever you think is fair I'm good with whatever either way

Should be instant so there's an issue. Either way we are moving to our kernel-plugin architecture which will make testing and implementation of all of these features far more robust

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 20, 2024

/start

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented Feb 20, 2024

DeadlineTue, Feb 20, 9:19 PM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@ubiquibot ubiquibot bot mentioned this issue Feb 25, 2024
Closed
@0x4007
Copy link
Member

0x4007 commented Feb 26, 2024

It's weird that GitHub is not considering your "closing keyword" an official link to this event. It's instead just considering it as a "mention"

@0x4007 0x4007 closed this as completed Feb 26, 2024
@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented Feb 26, 2024 

+ Evaluating results. Please wait...

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented Feb 26, 2024

[ 50 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueComment36.9
ReviewComment743.1
Conversation Incentives
CommentFormattingRelevanceReward
Not sure if this is a two or four hour task...
1.10.21.1
> The bot hasn't linked me yet, I'm not going to assign myself a...
3.20.523.2
It's weird that GitHub is not considering your "closing keyword"...
2.60.542.6
Your code is outdated. Pull from head...
0.70.370.7
I got it under one second on my [branch](https://github.com/pavl...
2.7 
a:
  count: 1
  score: "1"
  words: 1
0.652.7
> As did I without the additional 15 rpc calls however it's a go...
4.10.644.1
I was going to merge yours in but I realized that its not stable...
5.80.695.8
> I'm a little confused as to what you mean by it's not currentl...
20.2 
a:
  count: 1
  score: "1"
  words: 3
code:
  count: 4
  score: "4"
  words: 6
0.7820.2
Let me spend some time testing today and I'll be careful to clea...
4.10.84.1
The error that I got is from. 
erc20-permit.ts:67 Error:...</a></h6></td><td><details><summary>5.5</summary>
<pre>code:
  count: 1
  score: "1"
  words: 0
</pre>
</details></td><td>0.78</td><td>5.5</td></tr></tbody></table>
  </details>
  

  <details>
    <summary>
      <b
        ><h3>
          <a
            href="https://pay.ubq.fi/?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiI0MzU3MDAwMDAwMDAwMDAwMDAwMDAifSwibm9uY2UiOiIzNjkyNjE3MTgyMjY4NTcwODEwNzAyNDQ2MzY1NDE4NjIxOTU3NDc4MzY4Nzg4NDc5NDk4NjAyMTQwNDU3NjI5Njk3MTQ2MzQxNjQ4OSIsImRlYWRsaW5lIjoiMTE1NzkyMDg5MjM3MzE2MTk1NDIzNTcwOTg1MDA4Njg3OTA3ODUzMjY5OTg0NjY1NjQwNTY0MDM5NDU3NTg0MDA3OTEzMTI5NjM5OTM1In0sInRyYW5zZmVyRGV0YWlscyI6eyJ0byI6IjB4QWU1RDFGMTkyMDEzZGI4ODliMWUyMTE1QTM3MGFCMTMzZjM1OTc2NSIsInJlcXVlc3RlZEFtb3VudCI6IjQzNTcwMDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4NDRDYTE1RGIxMDFmRDFjMTk0NDY3RGI2QUYwYzY3QzZCYkY0QUI1MSIsInNpZ25hdHVyZSI6IjB4YTJmNjkxYjVjZDkxMzJlYjllYzJlMjI1NzRiMTkxYWUxZDRhNzkzOGI0MTQ4ZDAwZTI0ZjhhN2Y3NTM3MmFlOTVmMzIyY2VlZjg5MzFlN2ZkZDYxOWNlYzNkNDA1NTNlOTZmNTg0OTFhOGJlMDU3NTBjYTY3ZDM0NGQ4YTIwY2ExYyIsIm5ldHdvcmtJZCI6MTAwfV0%3D"
          >
            [ 435.7 WXDAI ]</a
          >
        </h3>
        <h6>@Keyrxng</h6></b
      >
    </summary>
    <h6>Contributions Overview</h6>
<table><thead>
<tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th>
</thead><tbody>
<tr><td>Issue</td><td>Specification</td><td>1</td><td>19</td></tr>
<tr><td>Issue</td><td>Task</td><td>1</td><td>200</td></tr>
<tr><td>Issue</td><td>Comment</td><td>1</td><td>6.4</td></tr>
<tr><td>Issue</td><td>Comment</td><td>1</td><td>0</td></tr>
<tr><td>Review</td><td>Comment</td><td>10</td><td>140.2</td></tr>
<tr><td>Review</td><td>Comment</td><td>10</td><td>70.1</td></tr>
</tbody></table>
    <h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/issues/168">Follow-on task to #158 

The goal is to reduce TTC (time till ...</a></h6></td><td><details><summary>19</summary>
<pre>li:
  count: 4
  score: "4"
  words: 53
</pre>
</details></td><td>1</td><td>19</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/issues/168#issuecomment-1954639846">The bot hasn't linked me yet, I'm not going to assign myself and...</a></h6></td><td>6.4</td><td>0.05</td><td>6.4</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/issues/168#issuecomment-1954639846">The bot hasn't linked me yet, I'm not going to assign myself and...</a></h6></td><td>-</td><td>0.05</td><td>-</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1954683499">lmao I'll get there sooner or later with Git 😂 ...</a></h6></td><td>2</td><td>0.05</td><td>2</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957269289">Optimistic rendering time till claimable:

![optimistic-w-add-...</a></h6></td><td>2.2</td><td>0.57</td><td>2.2</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957280053">had a nightmare trying to get that submodule added, thats what c...</a></h6></td><td>11.2</td><td>0.29</td><td>11.2</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957348255">The rpc speed mapping is cool but I think it's a bit overkill pi...</a></h6></td><td>23.8</td><td>0.5</td><td>23.8</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957797441">It's not determined by a block being mined as it involves no onc...</a></h6></td><td>12.6</td><td>0.505</td><td>12.6</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957817839">> > It's not determined by a block being mined as it involves no...</a></h6></td><td><details><summary>18.6</summary>
<pre>code:
  count: 1
  score: "2"
  words: 3
</pre>
</details></td><td>0.52</td><td>18.6</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957841044">As did I without the additional 15 rpc calls however it's a good...</a></h6></td><td>6.6</td><td>0.59</td><td>6.6</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1960692481">I'm a little confused as to what you mean by it's not currently ...</a></h6></td><td><details><summary>27.8</summary>
<pre>a:
  count: 1
  score: "2"
  words: 3
code:
  count: 4
  score: "8"
  words: 6
</pre>
</details></td><td>0.75</td><td>27.8</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1961222782">Hitting localhost I generated 10 permits with an open window eac...</a></h6></td><td><details><summary>16.6</summary>
<pre>code:
  count: 1
  score: "2"
  words: 7
</pre>
</details></td><td>0.71</td><td>16.6</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1963541663">This resolves the no network issue. 

I test by setting the ``...</a></h6></td><td><details><summary>18.8</summary>
<pre>code:
  count: 5
  score: "10"
  words: 7
</pre>
</details></td><td>0.76</td><td>18.8</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1954683499">lmao I'll get there sooner or later with Git 😂 ...</a></h6></td><td>1</td><td>0.05</td><td>1</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957269289">Optimistic rendering time till claimable:

![optimistic-w-add-...</a></h6></td><td>1.1</td><td>0.57</td><td>1.1</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957280053">had a nightmare trying to get that submodule added, thats what c...</a></h6></td><td>5.6</td><td>0.29</td><td>5.6</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957348255">The rpc speed mapping is cool but I think it's a bit overkill pi...</a></h6></td><td>11.9</td><td>0.5</td><td>11.9</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957797441">It's not determined by a block being mined as it involves no onc...</a></h6></td><td>6.3</td><td>0.505</td><td>6.3</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957817839">> > It's not determined by a block being mined as it involves no...</a></h6></td><td><details><summary>9.3</summary>
<pre>code:
  count: 1
  score: "1"
  words: 3
</pre>
</details></td><td>0.52</td><td>9.3</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957841044">As did I without the additional 15 rpc calls however it's a good...</a></h6></td><td>3.3</td><td>0.59</td><td>3.3</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1960692481">I'm a little confused as to what you mean by it's not currently ...</a></h6></td><td><details><summary>13.9</summary>
<pre>a:
  count: 1
  score: "1"
  words: 3
code:
  count: 4
  score: "4"
  words: 6
</pre>
</details></td><td>0.75</td><td>13.9</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1961222782">Hitting localhost I generated 10 permits with an open window eac...</a></h6></td><td><details><summary>8.3</summary>
<pre>code:
  count: 1
  score: "1"
  words: 7
</pre>
</details></td><td>0.71</td><td>8.3</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1963541663">This resolves the no network issue. 

I test by setting the ``...</a></h6></td><td><details><summary>9.4</summary>
<pre>code:
  count: 5
  score: "5"
  words: 7
</pre>
</details></td><td>0.76</td><td>9.4</td></tr></tbody></table>
  </details>
  

  <details>
    <summary>
      <b
        ><h3>
          <a
            href="https://pay.ubq.fi/?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiI5OTAwMDAwMDAwMDAwMDAwMDAwIn0sIm5vbmNlIjoiMTE0MTU0MTY3NDA3NTQxMTMxOTk2NTk0MjU5NzQzMjQ1MTcyNDcxOTU3MTM2MzUyMDQ3MjQ1Mzg4NzIwNDM1NTk5NjYzMzU2OTU4MTA3IiwiZGVhZGxpbmUiOiIxMTU3OTIwODkyMzczMTYxOTU0MjM1NzA5ODUwMDg2ODc5MDc4NTMyNjk5ODQ2NjU2NDA1NjQwMzk0NTc1ODQwMDc5MTMxMjk2Mzk5MzUifSwidHJhbnNmZXJEZXRhaWxzIjp7InRvIjoiMHgzMzZDMDMzODQyRkEzMTZkNDcwZTgyMGM4MWI3NDJlNjJBMDc2NURDIiwicmVxdWVzdGVkQW1vdW50IjoiOTkwMDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4NDRDYTE1RGIxMDFmRDFjMTk0NDY3RGI2QUYwYzY3QzZCYkY0QUI1MSIsInNpZ25hdHVyZSI6IjB4MDI3OThkMTljMjE0MDg3Mzk2NmFjYWY3NTFiMTlkNmM2ZmEyMjBjM2MwZTkyZTExOWVlMzI0NzBjNGViOGFjNTAwNzdjODJkZjQyMDdkZWE3MTk1ZDJhNzRkNTI0NTQyM2UwYjY1ODZmMWIwYWUyNzVjZmE0ODE0OWY5NWQ4MTcxYiIsIm5ldHdvcmtJZCI6MTAwfV0%3D"
          >
            [ 9.9 WXDAI ]</a
          >
        </h3>
        <h6>@rndquu</h6></b
      >
    </summary>
    <h6>Contributions Overview</h6>
<table><thead>
<tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th>
</thead><tbody>
<tr><td>Review</td><td>Comment</td><td>2</td><td>9.9</td></tr>
</tbody></table>
    <h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957785172">> local anvil hits instantly everytime

As far as I remember w...</a></h6></td><td><details><summary>5.5</summary>
<pre>a:
  count: 1
  score: "1"
  words: 1
</pre>
</details></td><td>0.59</td><td>5.5</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/169#issuecomment-1957804369">> It's not determined by a block being mined as it involves no o...</a></h6></td><td><details><summary>4.4</summary>
<pre>code:
  count: 1
  score: "1"
  words: 3
</pre>
</details></td><td>0.44</td><td>4.4</td></tr></tbody></table>
  </details>
  
<!-- Ubiquity - Transactions - generatePermits - 385a90e
[
  {
    "permit": {
      "permitted": {
        "token": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d",
        "amount": "50000000000000000000"
      },
      "nonce": "25331363610953184883986357106306410306408028531826745506077436890071399999461",
      "deadline": "115792089237316195423570985008687907853269984665640564039457584007913129639935"
    },
    "transferDetails": {
      "to": "0x4007CE2083c7F3E18097aeB3A39bb8eC149a341d",
      "requestedAmount": "50000000000000000000"
    },
    "owner": "0x44Ca15Db101fD1c194467Db6AF0c67C6BbF4AB51",
    "signature": "0xb6d8ad4f077f6d11d3cfa8ce8204daf33926e50f77e1945daefb42bc9d4931353e2f778b071e6b143eb7aff39c6c1d4da8f38e1358c585f0a27fdcc4b2012ee01c",
    "networkId": 100
  },
  {
    "permit": {
      "permitted": {
        "token": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d",
        "amount": "435700000000000000000"
      },
      "nonce": "36926171822685708107024463654186219574783687884794986021404576296971463416489",
      "deadline": "115792089237316195423570985008687907853269984665640564039457584007913129639935"
    },
    "transferDetails": {
      "to": "0xAe5D1F192013db889b1e2115A370aB133f359765",
      "requestedAmount": "435700000000000000000"
    },
    "owner": "0x44Ca15Db101fD1c194467Db6AF0c67C6BbF4AB51",
    "signature": "0xa2f691b5cd9132eb9ec2e22574b191ae1d4a7938b4148d00e24f8a7f75372ae95f322ceef8931e7fdd619cec3d40553e96f58491a8be05750ca67d344d8a20ca1c",
    "networkId": 100
  },
  {
    "permit": {
      "permitted": {
        "token": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d",
        "amount": "9900000000000000000"
      },
      "nonce": "114154167407541131996594259743245172471957136352047245388720435599663356958107",
      "deadline": "115792089237316195423570985008687907853269984665640564039457584007913129639935"
    },
    "transferDetails": {
      "to": "0x336C033842FA316d470e820c81b742e62A0765DC",
      "requestedAmount": "9900000000000000000"
    },
    "owner": "0x44Ca15Db101fD1c194467Db6AF0c67C6BbF4AB51",
    "signature": "0x02798d19c2140873966acaf751b19d6c6fa220c3c0e92e119ee32470c4eb8ac50077c82df4207dea7195d2a74d5245423e0b6586f1b0ae275cfa48149f95d8171b",
    "networkId": 100
  }
]
-->

@0x4007
Copy link
Member

0x4007 commented Feb 26, 2024

[ 50 WXDAI ]

@pavlovcik

lol the permit rendering broke again.

@0x4007 0x4007 mentioned this issue Feb 26, 2024
Closed
@0x4007
Copy link
Member

0x4007 commented Feb 26, 2024

[ 435.7 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueSpecification119
IssueTask1200
IssueComment16.4
IssueComment10
ReviewComment10140.2
ReviewComment1070.1
Conversation Incentives
CommentFormattingRelevanceReward
Follow-on task to #158

The goal is to reduce TTC (time till ...

19

li:
  count: 4
  score: "4"
  words: 53
119
The bot hasn't linked me yet, I'm not going to assign myself and...
6.40.056.4
The bot hasn't linked me yet, I'm not going to assign myself and...
-0.05-
lmao I'll get there sooner or later with Git 😂 ...
20.052
Optimistic rendering time till claimable:

![optimistic-w-add-...

2.20.572.2
had a nightmare trying to get that submodule added, thats what c...
11.20.2911.2
The rpc speed mapping is cool but I think it's a bit overkill pi...
23.80.523.8
It's not determined by a block being mined as it involves no onc...
12.60.50512.6
> > It's not determined by a block being mined as it involves no...
18.6

code:
  count: 1
  score: "2"
  words: 3
0.5218.6
As did I without the additional 15 rpc calls however it's a good...
6.60.596.6
I'm a little confused as to what you mean by it's not currently ...
27.8 
a:
  count: 1
  score: "2"
  words: 3
code:
  count: 4
  score: "8"
  words: 6
0.7527.8
Hitting localhost I generated 10 permits with an open window eac...
16.6 
code:
  count: 1
  score: "2"
  words: 7
0.7116.6
This resolves the no network issue.

I test by setting the ``...

18.8

code:
  count: 5
  score: "10"
  words: 7
0.7618.8
lmao I'll get there sooner or later with Git 😂 ...
10.051
Optimistic rendering time till claimable:

![optimistic-w-add-...

1.10.571.1
had a nightmare trying to get that submodule added, thats what c...
5.60.295.6
The rpc speed mapping is cool but I think it's a bit overkill pi...
11.90.511.9
It's not determined by a block being mined as it involves no onc...
6.30.5056.3
> > It's not determined by a block being mined as it involves no...
9.3

code:
  count: 1
  score: "1"
  words: 3
0.529.3
As did I without the additional 15 rpc calls however it's a good...
3.30.593.3
I'm a little confused as to what you mean by it's not currently ...
13.9 
a:
  count: 1
  score: "1"
  words: 3
code:
  count: 4
  score: "4"
  words: 6
0.7513.9
Hitting localhost I generated 10 permits with an open window eac...
8.3 
code:
  count: 1
  score: "1"
  words: 7
0.718.3
This resolves the no network issue.

I test by setting the ``...

9.4

code:
  count: 5
  score: "5"
  words: 7
0.769.4

[ 9.9 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment29.9
Conversation Incentives
CommentFormattingRelevanceReward
> local anvil hits instantly everytime

As far as I remember w...

5.5

a:
  count: 1
  score: "1"
  words: 1
0.595.5
> It's not determined by a block being mined as it involves no o...
4.4 
code:
  count: 1
  score: "1"
  words: 3
0.444.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keyrxng Keyrxng

Labels
Price: 200 USD Priority: 2 (Medium) Time: <4 Hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sub 1s loading UI ubq-testing/pay.ubq.fi
2 participants
@0x4007 @Keyrxng