Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent posting duplicated deployment URLs #14

Open
rndquu opened this issue Jun 18, 2024 · 13 comments · Fixed by #15 · May be fixed by #25
Open

Prevent posting duplicated deployment URLs #14

rndquu opened this issue Jun 18, 2024 · 13 comments · Fixed by #15 · May be fixed by #25
Assignees
@Sadaf-A
Labels
Price: 25 USD Priority: 1 (Normal) Time: <1 Hour

Comments

@rndquu
Copy link
Member

rndquu commented Jun 18, 2024

Check this comment where commit hash c124c0a is duplicated multiple times. It happened because of multiple failed deploy attempts in this CI run.

Expected behavior is that commit hash c124c0a is posted only once.

What should be done:

  • don't post deployment URL if it already exists
@ubiquibot ubiquibot bot mentioned this issue Jun 18, 2024
Open
@Sadaf-A
Copy link
Contributor

Sadaf-A commented Jul 12, 2024

/start

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented Jul 12, 2024

DeadlineFri, Jul 12, 12:34 PM UTC
Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@Sadaf-A Sadaf-A mentioned this issue Jul 12, 2024
Merged
@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented Jul 12, 2024 

+ Evaluating results. Please wait...

@ubiquibot-dev UbiquiBot[dev]
Copy link

ubiquibot-dev bot commented Jul 12, 2024 •
edited
Loading

[ 25 WXDAI ]

@Sadaf-A
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Conversation Incentives
Comment Formatting Relevance Reward

[ 5.1 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Specification 1 5.1
Conversation Incentives
Comment Formatting Relevance Reward
Check [this](https://github.com/ubiquity/pay.ubq.fi/pull/253#iss…
5.1 
content:
  p:
    count: 47
    score: 1
  a:
    count: 2
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.1

[ 0.5 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Review Comment 1 0.5
Conversation Incentives
Comment Formatting Relevance Reward
Code looks good. Do you have any tests to show it has the expect…
2.5 
content:
  p:
    count: 25
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.2 0.5

@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented Jul 12, 2024

[ 2.6 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
ReviewComment12.6
Conversation Incentives
CommentFormattingRelevanceReward
Code looks good. Do you have any tests to show it has the expect...
2.60.352.6

[ 25 WXDAI ]

@Sadaf-A
Contributions Overview
ViewContributionCountReward
IssueTask125

[ 14.4 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification114.4
Conversation Incentives
CommentFormattingRelevanceReward
Check [this](https://github.com/ubiquity/pay.ubq.fi/pull/253#iss...
14.4 
a:
  count: 2
  score: "2"
  words: 2
li:
  count: 1
  score: "1"
  words: 9
code:
  count: 2
  score: "2"
  words: 2
114.4

@rndquu rndquu reopened this Oct 9, 2024
@rndquu
Copy link
Member Author

rndquu commented Oct 9, 2024

Duplicated items ubiquity/pay.ubq.fi#330 (comment)

@0x4007
Copy link
Member

0x4007 commented Oct 10, 2024

I've noticed this behavior recently I have a feeling I might have broken it when changing around all the CI

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Dec 20, 2024

@0x4007 So, is this issue resolved or not?

@rndquu
Copy link
Member Author

rndquu commented Dec 21, 2024

@0x4007 So, is this issue resolved or not?

Not resolved, check this comment

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Dec 21, 2024

@0x4007 So, is this issue resolved or not?

Not resolved, check this comment

So, how can it be resolved cause I opened a PR and it was approved

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Dec 21, 2024

/start

@Sadaf-A Sadaf-A linked a pull request Dec 21, 2024 that will close this issue
Open
@Sadaf-A
Copy link
Contributor

Sadaf-A commented Dec 23, 2024

@rndquu could I be assigned to this since I have an open PR.

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Jan 2, 2025

@UbiquityOS how do I QA for this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sadaf-A Sadaf-A

Labels
Price: 25 USD Priority: 1 (Normal) Time: <1 Hour
Projects
None yet
Milestone
No milestone
3 participants
@0x4007 @Sadaf-A @rndquu