Properly set the metadata value of LogReturn
#41
Assignees
Comments
gentlementlegen
changed the title
metadata value of LogReturn
This comment was marked as spam.
This comment was marked as spam.
Tip
|
|
Passed the deadline and no activity is detected, removing assignees: @imabutahersiddik. |
|
@gentlementlegen we gonna built it into the logger or keep it within the sdk? |
|
@Keyrxng The SDK itself uses the logger but maybe having this metadata in the logger pollutes the code base too much as it is specific to GitHub comments probably. |
|
I thought something similar, so best to keep it all within the SDK in error metadata. Can close this or transfer it or whatever as it's resolved within the SDK following the merge of gentlementlegen/ubiquity-os-kernel#1 (will PR the SDK repo now that there is one) |
|
@Keyrxng should we reopen the PR then? |
|
I'm including all of the logic for this directly into the SDK right? If so then yeah I'll PR the SDK. Just seen foo's comment re: SDK separation complicating things. Waiting to see if the SDK moves back into the kernel or stays separate |
|
@Keyrxng Also goes for the PR you just closed I guess. |
Yes unfortunately, would have been ideal if you had managed to merge into your improvements PR like you suggested but it's all good I'll just re-do them. I assume the SDK is 100% staying separate from the kernel then yeah and I should PR against it? |
|
Let's see how we do it. If the circular reference can be fixed it can remain inside the kernel and it's fine. |
|
Moving this to |
! Error: TypeError: Cannot read properties of null (reading 'node') |
Tip
|
+ Evaluating results. Please wait... |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 18 |
| Issue | Specification | 1 | 37.62 |
| Issue | Comment | 5 | 13.014 |
| Review | Comment | 1 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
Revision should point to the current version of the plugin. With… | 12.54content:
content:
p:
score: 0
elementCount: 3
em:
score: 0
elementCount: 1
a:
score: 5
elementCount: 2
result: 10
regex:
wordCount: 45
wordValue: 0.1
result: 2.54
| 1 | 3 | 37.62 |
@Keyrxng The SDK itself uses the logger but maybe having this me… | 1.75content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 29
wordValue: 0.1
result: 1.75
| 0.8 | 3 | 4.2 |
@Keyrxng should we reopen the PR then? | 0.52content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0.1
result: 0.52
| 0.5 | 3 | 0.78 |
@Keyrxng Also goes for the PR you just closed I guess. | 0.77content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 0.4 | 3 | 0.924 |
Let's see how we do it. If the circular reference can be fixed i… | 1.49content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 24
wordValue: 0.1
result: 1.49
| 1 | 3 | 4.47 |
Moving this to `plugin-sdk` as it handles what gets insi… | 0.88content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 13
wordValue: 0.1
result: 0.88
| 1 | 3 | 2.64 |
Resolves #41 | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0
result: 0
| 0.1 | 3 | 0 |
[ 12.402 WXDAI ]
@Keyrxng
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 4 | 12.402 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
@gentlementlegen we gonna built it into the logger or keep it wi… | 0.94content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 14
wordValue: 0.1
result: 0.94
| 1 | 3 | 0.72 |
I thought something similar, so best to keep it all within the S… | 7.54content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 45
wordValue: 0.1
result: 2.54
| 1 | 3 | 5.67 |
I'm including all of the logic for this directly into the SDK ri… | 7.64content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 47
wordValue: 0.1
result: 2.64
| 0.8 | 3 | 4.584 |
Yes unfortunately, would have been ideal if you had managed to m… | 2.73content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 49
wordValue: 0.1
result: 2.73
| 0.7 | 3 | 1.428 |
[ 4.623 WXDAI ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Comment | 7 | 4.623 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
```suggestionThe `postComment` function ena… | 0content:
content: {}
result: 0
regex:
wordCount: 0
wordValue: 0.1
result: 0
| 0.5 | 3 | 0 |
This should be handled all in the SDK | 0.59content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 8
wordValue: 0.1
result: 0.59
| 0.7 | 3 | 1.239 |
I didn't mean to post this pending comment | 0.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0.1
result: 0.65
| 0 | 3 | 0 |
Code changes look fine. Interested to see the rendered metadata… | 0.94content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 14
wordValue: 0.1
result: 0.94
| 0.4 | 3 | 1.128 |
Looks informative but what is the second field with the value of… | 0.94content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 14
wordValue: 0.1
result: 0.94
| 0.2 | 3 | 0.564 |
Sure we can leave it then. | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.3 | 3 | 0.414 |
Actually the invoker field should be last for search reasons. | 0.71content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 10
wordValue: 0.1
result: 0.71
| 0.6 | 3 | 1.278 |
[ 18 WXDAI ]
@whilefoo
⚠️ Your rewards have been limited to the task price of 18 WXDAI.
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Comment | 9 | 25.602 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
To get the worker name kernel needs to be updated to send URL in… | 3.66content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 69
wordValue: 0.1
result: 3.66
| 0.8 | 3 | 8.784 |
These two ifs could be merged | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.7 | 3 | 0.966 |
what does `installation.account.name` refer to? | 0.32content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 4
wordValue: 0.1
result: 0.32
| 0.5 | 3 | 0.48 |
You could just set `logMessage` to `content` in … | 1.22content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0.1
result: 1.22
| 0.6 | 3 | 2.196 |
why not `message instanceof LogReturn`? | 0.18content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 2
wordValue: 0.1
result: 0.18
| 0.4 | 3 | 0.216 |
What's the point of assigning it again? I think it would look cl… | 1.17content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 18
wordValue: 0.1
result: 1.17
| 0.7 | 3 | 2.457 |
it's fine, I just didn't know what it is | 0.77content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 0.3 | 3 | 0.693 |
First time I'm hearing of this. Why would `fetch` manipu… | 3.61content:
content:
p:
score: 0
elementCount: 2
hr:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 68
wordValue: 0.1
result: 3.61
| 0.6 | 3 | 6.498 |
@gentlementlegen I think you missed my [comment](https://github.… | 5.52content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 7
wordValue: 0.1
result: 0.52
| 0.2 | 3 | 3.312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @gentlementlegen in ubiquity-os/ubiquity-os-kernel#169 (comment)
The text was updated successfully, but these errors were encountered: