Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision Related Annotations #30

Closed
0x4007 opened this issue Oct 3, 2024 · 4 comments · Fixed by #31
Closed

Precision Related Annotations #30

0x4007 opened this issue Oct 3, 2024 · 4 comments · Fixed by #31

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 3, 2024

While working on ubiquity-os/plugins-wishlist#3

I realized that the footnote situation is not very clear

image

I think the most elegant way for this system to integrate and not be an eyesore/distraction would be:

  1. Annotate the precise sentence that triggered a match.
  2. Remove the Similar [2] line in the above image
  3. Prefix the footnote with "⚠ xx% possible duplicate - "

Continue reading below. #30 (comment)

Similar 1

Footnotes

  1. Similar Issues Adjustments 82%

Copy link
Contributor

ubiquity-os bot commented Oct 3, 2024

Note

The following contributors may be suitable for this task:

sshivaditya2019

82% Match ubiquity-os-marketplace/generate-vector-embeddings#25

@0x4007
Copy link
Member Author

0x4007 commented Oct 3, 2024

I can't generate the footnote in the spec because of the similarity bot!

123

The expected footnote from the above example would look something more like:

Footnotes

  1. Although it is not clear to me how we can capture the event from this. I suppose I would need to manually add in the org/repo config for issue_comment.created.

  2. ⚠ 84% possible duplicate - 2025 Plugins Wishlist

  3. ⚠ 82% possible duplicate - New Task Or Edit Pull Arbiter

@shiv810
Copy link
Collaborator

shiv810 commented Oct 3, 2024

A Sample output would be like this:

Monitor performance and response times.1
Expected Behavior: Improved performance with caching enabled.
Current Behavior:2 Slower response times due to lack of caching.
Attachments: N/A

Footnotes

  1. ⚠ 84% possible duplicate - 2025 Plugins Wishlist

  2. Although it is not clear to me how we can capture the event from this. I suppose I would need to manually add in the org/repo config for issue_comment.created.

@0x4007
Copy link
Member Author

0x4007 commented Oct 3, 2024

The duplicate warnings should render last in footnotes. The footnotes from the spec should take priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants