-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
December 2024 Fixes #28
Comments
@gentlementlegen the deadline is at Thu, Dec 5, 5:01 AM UTC |
Another instance of the error: ubiquity-os/plugins-wishlist#31 (comment) |
Note The following contributors may be suitable for this task: rndquu
|
The |
The error is the following:
I believe the main problem is the error display that is wrong (should give this instead of [Object object]). |
@0x4007 The root of the error is that the wallet was already in our DB. Do we allow an address to be linked to multiple accounts? Shall we block this behavior? |
I see that's interesting. It's hard to say what's the right answer but I think we should not support sybils. To use the system you should only be using one GitHub account. There will be an incentive to use a single account when we have XP one day. You can make the error message clear, saying that the wallet is already registered. I suppose we can also make a note that they can unset their wallet address on the old account before setting on their new account in case they want to change the account that they use? |
Well that's the thing I don't think there is any way to "unset" wallets at this time. We could also implement that. I don't think it's a very common use case, only if you use multiple accounts or somehow lost your account and you use a new one? Here is a complete error for a duplicated account: Meniole#5 (comment) So I'd say either we allow multiple accounts linked to one wallet, either we offer a way to unset wallets from an account. |
It's useful for us to know who is a sybil. Maybe unsetting can be like /wallet null |
Okay then I would suggest something like |
+ Evaluating results. Please wait... |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 100 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|
[ 100 WXDAI ]
@0x4007
⚠️ Your rewards have been limited to the task price of 100 WXDAI.
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 37 |
Issue | Comment | 2 | 23.944 |
Review | Comment | 6 | 45.944 |
Conversation Incentives
Comment | Formatting | Relevance | Priority | Reward |
---|---|---|---|---|
Registration failures makes the system unusable. # Unnecessary… | 9.25content: content: p: score: 0 elementCount: 4 h1: score: 1 elementCount: 2 em: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 7 regex: wordCount: 39 wordValue: 0.1 result: 2.25 | 1 | 4 | 37 |
I see that's interesting. It's hard to say what's the right answ… | 5.05content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 101 wordValue: 0.1 result: 5.05 | 1 | 4 | 20.2 |
It's useful for us to know who is a sybil. Maybe unsetting can b… | 1.17content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0.1 result: 1.17 | 0.8 | 4 | 3.744 |
Code looks fine just need to include my QA comment adjustments. … | 1.06content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06 | 0.5 | 4 | 2.12 |
You can probably set it to null. | 0.52content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52 | 0.6 | 4 | 1.248 |
I realized that this double hyphen is really only geared towards… | 1.33content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33 | 0.7 | 4 | 3.724 |
Yes locations metadata caused things to be unnecessarily complic… | 2.15content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 37 wordValue: 0.1 result: 2.15 | 0.4 | 4 | 3.44 |
Did you test that this works? My original belief was that we wou… | 4.67content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 92 wordValue: 0.1 result: 4.67 | 0.8 | 4 | 14.944 |
I left some feedback there https://github.com/Meniole/command-wa… | 5.39content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 5 wordValue: 0.1 result: 0.39 | 0.3 | 4 | 20.468 |
For some reasons it seems that @whilefoo comments didn't get picked up here? I will have a look. |
They have had problems registering their wallet in the past so that may also be related. Lastly we still need to adjust the algorithm to not take a baseline from the formatting score. If relevance is 0 then the final score should be 0 |
@0x4007 That change was made after your request: ubiquity-os-marketplace/text-conversation-rewards#92 (comment) I will change it back. |
We have come a long way in a few months. There were a lot of problems when that was posted and I suppose I figured that would have been the quickest solution to slightly more accurate scoring. These days I think the scoring is much more accurate. Semi related to that but relevance currently doesn't understand image contents. Check this spec, specifically for vector embeddings but maybe we should write in the HTML comments the descriptions of the images? It could also be really interesting to pull the text contents from links to also score their relevance. |
@0x4007 you mean that when a user adds an image within a comment, it should also add some description within it? Like so? |
This should be discussed in the dedicated task |
Registration failures makes the system unusable.
Unnecessary Error
The previous error above it is sufficient this one should not display to the user.
! Error: Error: No wallet address found
Originally posted by @ubiquity-os[bot] in ubiquity/business-development#85 (comment)
Registration Failure
! Error: [object Object]
Originally posted by @ubiquity-os[bot] in ubiquity/business-development#85 (comment)
The text was updated successfully, but these errors were encountered: