Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotImplementedError when running generate_rollout #5

Open
agopal42 opened this issue Oct 11, 2019 · 5 comments
Open

NotImplementedError when running generate_rollout #5

agopal42 opened this issue Oct 11, 2019 · 5 comments

Comments

@agopal42
Copy link

Traceback (most recent call last):
File "/home/anand/IDSIA/mutual-information-keypoints/collect_atari_data.py", line 27, in
results = generate_rollout(m,min_frames=2500,max_frames=2500)
File "/home/anand/anaconda3/envs/tf-gpu/lib/python3.6/site-packages/atari_zoo/rollout.py", line 135, in generate_rollout
obs = env.reset()
File "/home/anand/anaconda3/envs/tf-gpu/lib/python3.6/site-packages/gym/core.py", line 258, in reset
return self.observation(observation)
File "/home/anand/anaconda3/envs/tf-gpu/lib/python3.6/site-packages/gym/core.py", line 265, in observation
raise NotImplementedError
NotImplementedError

@akolobov
Copy link

Same problem. Any workarounds?

@agopal42
Copy link
Author

It has to do with the API format for the methods like step(), reset(), render() etc. in atari_wrappers.py in atari_zoo which follow the old gym API format of using ._step(). By changing it to align with API format of the latest gym versions (0.15.3) by replacing the "._method_name()" with ".method_name()" and , it worked for me. Hope this helps!

@akolobov
Copy link

Yeah, thanks, just figured it out too! Instead of updating the model zoo code I went for installing gym==0.12.0 though.

@jal278
Copy link
Contributor

jal278 commented May 25, 2020

Should now be fixed -- updated code according to @agopal42 's suggestion

@akolobov
Copy link

@jal278 , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants