Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generated by mockgen on Windows should not be different #118

Closed
craig65535 opened this issue Nov 9, 2023 · 1 comment
Closed

Code generated by mockgen on Windows should not be different #118

craig65535 opened this issue Nov 9, 2023 · 1 comment

Comments

@craig65535
Copy link
Contributor

Code generated by mockgen on Windows machines has a different header comment from code generated on other platforms.

@@ -3,7 +3,7 @@
 //
 // Generated by this command:
 //
-//     mockgen -destination=mock_downloader.go -package downloader . Downloader
+//     mockgen.exe -destination=mock_downloader.go -package downloader . Downloader
 //
 // Package downloader is a generated GoMock package.
 package downloader
@craig65535 craig65535 mentioned this issue Nov 9, 2023
Merged
r-hang pushed a commit that referenced this issue Nov 17, 2023
@craig65535 @marten-seemann
MockGen header comment: trim .exe suffix on Windows (#119)
5b48f95 
To address #118

---------

Co-authored-by: Marten Seemann <[email protected]>
@r-hang
Copy link
Contributor

r-hang commented Nov 20, 2023

#119 has been merged.

@r-hang r-hang closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@craig65535 @r-hang