get rid of sync.Map for better go version compatibility
#13
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 65.97% 66.05% +0.07%
==========================================
Files 20 20
Lines 1743 1747 +4
==========================================
+ Hits 1150 1154 +4
Misses 511 511
Partials 82 82
Continue to review full report at Codecov.
|
| // stateModelName->stateModelProcessor | ||
| stateModelProcessors sync.Map | ||
| stateModelProcessorsMu sync.Mutex | ||
| stateModelProcessors map[string]*StateModelProcessor // state model name to processor |
There was a problem hiding this comment.
nit: let's avoid inline comment
| @@ -1,6 +1,7 @@ | |||
| language: go | |||
| go: | |||
| - 1.9 | |||
| - 1.8 | |||
There was a problem hiding this comment.
We should stick to 1.9 unless there's a huge demand for supporting 1.8.
There was a problem hiding this comment.
I'm not sure about the tradeoff between supporting more versions and losing the 1.9 specific features, but I agree we can punt on this PR and evaluate the tradeoff when demand for 1.8 (or below) really comes.
|
|
trying to resolve #7 to support Go 1.8