Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last inference node does not have eval #9

Open
mbartling opened this issue Jan 19, 2018 · 2 comments
Open

Last inference node does not have eval #9

mbartling opened this issue Jan 19, 2018 · 2 comments

Comments

@mbartling
Copy link
Member

mbartling commented Jan 19, 2018

The very last node in every graph is a Placeholder so no is_eval gets set for output nodes. Should be an easy fix

@dboyliao
Copy link
Member

Why does placeholder need evaluation?
According to the snippet, it's simply add a tensor into context object.
There is no operation to evaluate.

@dboyliao
Copy link
Member

As for the output nodes, they need no evaluation in the code we generate.
The rationale here is that we leave the output tensor (nodes) untouched so the user can get the tensor later and manually evaluate whenever they like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants